On 10/1/20 5:27 PM, John Snow wrote: > On 9/23/20 12:49 PM, Philippe Mathieu-Daudé wrote: >> On 9/23/20 5:37 PM, Eduardo Habkost wrote: >>> On Wed, Sep 23, 2020 at 11:17:01AM -0400, John Snow wrote: >>>> On 9/23/20 11:14 AM, Markus Armbruster wrote: >>>>> John Snow <js...@redhat.com> writes: >>>>> >>>>>> I'm proposing that I split the actual Python library off from the >>>>>> other >>>>>> miscellaneous python scripts we have and declare it maintained. Add >>>>>> myself as a maintainer of this folder, along with Cleber. >>>>>> >>>>>> v2: change python/* to python/, thanks Alex. >>>>>> >>>>>> Signed-off-by: John Snow <js...@redhat.com> >>>>>> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> >>>>>> Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> >>>>>> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> >>>>>> Acked-by: Cleber Rosa <cr...@redhat.com> >>>>>> Acked-by: Eduardo Habkost <ehabk...@redhat.com> >>>>>> --- >>>>>> MAINTAINERS | 9 ++++++++- >>>>>> 1 file changed, 8 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>>>> index 3d17cad19a..c0222ee645 100644 >>>>>> --- a/MAINTAINERS >>>>>> +++ b/MAINTAINERS >>>>>> @@ -2355,11 +2355,18 @@ S: Maintained >>>>>> F: include/sysemu/cryptodev*.h >>>>>> F: backends/cryptodev*.c >>>>>> +Python library >>>>>> +M: John Snow <js...@redhat.com> >>>>>> +M: Cleber Rosa <cr...@redhat.com> >>>>>> +R: Eduardo Habkost <ehabk...@redhat.com> >>>>>> +S: Maintained >>>>>> +F: python/ >>>>>> +T: git https://gitlab.com/jsnow/qemu.git python >>>>>> + >>>>>> Python scripts >>>>>> M: Eduardo Habkost <ehabk...@redhat.com> >>>>>> M: Cleber Rosa <cr...@redhat.com> >>>>>> S: Odd fixes >>>>>> -F: python/qemu/*py >>>>>> F: scripts/*.py >>>>>> F: tests/*.py >>>>> >>>>> Separate sections just so you can have the appropriate S:, or is >>>>> there a >>>>> deeper logic behind the split? >>>>> >>>> >>>> Yes, different intended levels of support. I don't currently have the >>>> bandwidth to promise support for the miscellaneous Python scripts in >>>> ./scripts, but I do promise to support to a higher level the code in >>>> ./python. >>>> >>>> Over time, I intend to migrate things into ./python, but there are some >>>> series that need to happen first before I start doing that. >>> >>> Also, the actual owners for most scripts in ./scripts are already >>> listed elsewhere. I believe we shouldn't really have M: lines >>> for the scripts/*.py section, just R:. >> >> Agreed. Maybe worth a comment in the section although. >> > > *in* the section? There is no precedent for that. Is this really so > important?
Well if this file is only consumed by scripts, and no human reads it, then it is pointless indeed. > > I'll give you a commit message blurb. That sometime works, thanks. > > --js >
