On Mon, Sep 14, 2020 at 3:06 PM Stefano Garzarella <sgarz...@redhat.com> wrote:
>
> Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
> introduced namespace support for RBD, but we forgot to add the
> new 'namespace' options to qemu_rbd_strong_runtime_opts[].
>
> The 'namespace' is used to identify the image, so it is a strong
> option since it can changes the data of a BDS.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1821528
> Fixes: 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
> Cc: Florian Florensa <fflore...@online.net>
> Signed-off-by: Stefano Garzarella <sgarz...@redhat.com>
> ---
> block/rbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index 688074c64b..5356753fbe 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -1289,6 +1289,7 @@ static QemuOptsList qemu_rbd_create_opts = {
>
> static const char *const qemu_rbd_strong_runtime_opts[] = {
> "pool",
> + "namespace",
> "image",
> "conf",
> "snapshot",
> --
> 2.26.2
>
lgtm
Reviewed-by: Jason Dillaman <dilla...@redhat.com>
--
Jason
