Il gio 27 ago 2020, 18:05 Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> ha scritto:
> On 26/08/2020 07:45, Paolo Bonzini wrote: > > > On Tue, Aug 25, 2020 at 11:26 PM Mark Cave-Ayland > > <mark.cave-ayl...@ilande.co.uk> wrote: > >> I've tested this and it changes build.ninja so instead of Windows paths > beginning C$$ > >> they now begin C$ instead e.g.: > >> > >> build qemu-version.h: CUSTOM_COMMAND | > >> C$:/msys64/home/Mark/qemu/scripts/qemu-version.sh PHONY > > > > The patch should not change build.ninja in any way, but indeed it will > > fix the transformation so that the (correct) ninja quoting is removed. > > It definitely changes build.ninja here, with the escaping changing from > C$$:\ to C$:\ > in my tests. Yes, the ^ makes no difference but I missed that it also adds a $. Thanks for testing!! Paolo if you're saying that $: with just a single $ is the correct > escaping for colon then I guess the patch is fine (and indeed it works for > me with > the $ now being removed in the transformation to Makefile.ninja). > > > ATB, > > Mark. > >