On Tue, Aug 25, 2020 at 11:31 PM Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > On 25/08/2020 17:53, luoyongg...@gmail.com wrote: > > > From: Yonggang Luo <luoyongg...@gmail.com> > > > > On win32, os.path.relpath would raise exception when do the following > > relpath: > > C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail. > > So we try catch it for stopping it from raise exception on msys2 > I don't think this is relevant in my particular environment, however it > didn't seem > to break the build. I'm curious as to why os.path.relpath throws an exception > in this > particular case on Windows though - can you give us a bit more information > about the > Exception that is being thrown?
I think it's because it's impossible to make a relative path between two different drives. The patch is correct but is missing the Signed-off-by line. Paolo
