On 8/24/20 9:59 AM, Peter Maydell wrote: >> + bool sve_access_checked; > > Is there anywhere it's worthwhile to put in an equivalent > of assert_fp_access_checked() for sve_access_checked, or is > there no point that's both (a) common to SVE accesses and > (b) not common to generic FP accesses ? One could put it > in pred_full_reg_offset() I suppose but I dunno if that > really gains us much. The existing fp_access_checked will > catch "forgot the check entirely" which seems more likely > as a bug than "put in the FP check when we wanted SVE".
While adding one to pred_full_ref_offset() might be useful, there are plenty of sve instructions that don't touch predicate registers. I suppose I could make vec_full_reg_offset() be different between translate-a64.c and translate-sve.c, rather than sharing it via translate-a64.h. r~
