Thomas Huth <th...@redhat.com> writes:
> On 23/07/2020 16.27, Markus Armbruster wrote:
>> Markus Armbruster (3):
>> scripts/qmp/qom-fuse: Unbreak import of QEMUMonitorProtocol
>> scripts/qmp/qom-fuse: Port to current Python module fuse
>> scripts/qmp/qom-fuse: Fix getattr(), read() for files in /
>
> Could it be added to a CI pipeline, so that it does not bitrot again?
Should it be?
Thread hijack!
What's the status of scripts/qmp/?
The directory is covered by MAINTAINERS section QMP, with status
"Supported". Status is a *lie* for these scripts. I inherited them
with the rest of QMP. I have no use for them, except I occasionally use
qom-fuse for QOM spelunking, mostly because our monitor commands are so
unwieldy compared to a filesystem. I barely looked at them in the 5+
years of my service as QMP maintainer. Actual status is "Odd fixes".
Does this stuff have any business in /scripts/?
Nothing in scripts/qmp/ should be shipped.
scripts/qmp/qemu-ga-client doesn't even belong there. Michael, is it of
any use today?
I know scripts/qmp/qmp-shell has a few friends among developers. I
regard it as a failed attempt at making QMP easier for humans, and have
zero interest in it.
scripts/qmp/qmp looks like an attempt at making QMP easier for shell
scripts. I'm not aware of actual use, and have zero interest in it.
scripts/qmp/qom-{get,list,set} look like an attempt at making QOM easier
for shell scripts. I'm not aware of actual use, and have zero interest
in it. Heck, I can't even figure out how to use qom-get (I just spend
at least 30s trying).
scripts/qmp/qom-tree feels redundant with scripts/qmp/qom-fuse. I just
ran it for the first time just to come to this judgement.
I believe contrib/ would be a better home for all of them.
I feel like moving the directory there and leaving it *uncovered* in
MAINTAINERS. If a volunteer steps forward, we can add a suitable
section.
Opinions?
