Philippe Mathieu-Daudé <phi...@redhat.com> writes:
> On 7/23/20 4:27 PM, Markus Armbruster wrote:
>> path, prop = "type".rsplit('/', 1) sets path to "", which doesn't
>> work. Correct to "/".
>>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> scripts/qmp/qom-fuse | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/qmp/qom-fuse b/scripts/qmp/qom-fuse
>> index 405e6ebd67..7c7cff8edf 100755
>> --- a/scripts/qmp/qom-fuse
>> +++ b/scripts/qmp/qom-fuse
>> @@ -45,8 +45,10 @@ class QOMFS(Operations):
>> return False
>>
>> def is_property(self, path):
>> + path, prop = path.rsplit('/', 1)
>> + if path == '':
>> + path = '/'
>> try:
>> - path, prop = path.rsplit('/', 1)
>
> Maybe worth adding an tiny root_path_split() helper?
The script goes back to commit 5ade767485 "qom: quick and dirty QOM
filesystem based on FUSE" (2014). It's as "quick and dirty" as ever.
It could use a thorough rework.
> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Thanks!
[...]
