HI Philippe, > -----Original Message----- > From: Philippe Mathieu-Daudé <phi...@redhat.com> > Sent: Thursday, June 25, 2020 1:48 PM > To: Markus Armbruster <arm...@redhat.com>; Sai Pavan Boddu > <saip...@xilinx.com>; Thomas Huth <th...@redhat.com> > Cc: Gerd Hoffmann <kra...@redhat.com>; Peter Maydell > <peter.mayd...@linaro.org>; Eduardo Habkost <ehabk...@redhat.com>; > qemu-devel@nongnu.org; Alistair Francis <alistair.fran...@wdc.com>; > 'Marc-André Lureau' <marcandre.lur...@redhat.com>; Ying Fang > <fangyi...@huawei.com>; Paolo Bonzini <pbonz...@redhat.com> > Subject: Re: [PATCH v2 2/3] usb/hcd-xhci: Move qemu-xhci device to hcd- > xhci-pci.c > > On 6/25/20 10:06 AM, Markus Armbruster wrote: > > Sai Pavan Boddu <sai.pavan.bo...@xilinx.com> writes: > > > >> Move pci specific devices to new file. This set the environment to > >> move all pci specific hooks in hcd-xhci.c to hcd-xhci-pci.c. > >> > >> Signed-off-by: Sai Pavan Boddu <sai.pavan.bo...@xilinx.com> > >> --- > >> hw/usb/hcd-xhci-pci.c | 64 > +++++++++++++++++++++++++++++++++++++++++++++++++++ > >> hw/usb/hcd-xhci.c | 32 ++------------------------ > >> hw/usb/hcd-xhci.h | 2 ++ > >> 3 files changed, 68 insertions(+), 30 deletions(-) create mode > >> 100644 hw/usb/hcd-xhci-pci.c > >> > >> diff --git a/hw/usb/hcd-xhci-pci.c b/hw/usb/hcd-xhci-pci.c new file > >> mode 100644 index 0000000..26af683 > >> --- /dev/null > >> +++ b/hw/usb/hcd-xhci-pci.c > >> @@ -0,0 +1,64 @@ > >> +/* > >> + * USB xHCI controller with PCI system bus emulation > > > > Scratch "system". > > > >> + * > >> + * Copyright (c) 2011 Securiforest > >> + * Date: 2011-05-11 ; Author: Hector Martin <hec...@marcansoft.com> > > > > Let's use the opportunity to drop the "Date: " part, because we don't > > have it anywhere else. > > Good opportunity to suggest the SPDX tags again :P > > /* > * SPDX-FileCopyrightText: 2011 Securiforest > * SPDX-FileContributor: Hector Martin <hec...@marcansoft.com> > * SPDX-FileCopyrightText: 2020 Xilinx Inc. > * SPDX-FileContributor: Sai Pavan Boddu <sai.pavan.bo...@xilinx.com> > * SPDX-License-Identifier: GPL-2.0-or-later */ [Sai Pavan Boddu] I would include this in V4, Forgot them in V3.
Thanks, Sai Pavan > > https://spdx.org/rdf/ontology/spdx-2-0- > rc/dataproperties/fileContributor___-1635717172.html > > > > >> + * Based on usb-ohci.c, emulates Renesas NEC USB 3.0 > >> + * Date: 2020-03-01; Author: Sai Pavan Boddu > >> + <sai.pavan.bo...@xilinx.com> > > > > And no new "Date: " parts, please. > > > >> + * Moved the pci specific content for hcd-xhci.c to hcd-xhci-pci.c > >> + * > >> + * This library is free software; you can redistribute it and/or > >> + * modify it under the terms of the GNU Lesser General Public > >> + * License as published by the Free Software Foundation; either > >> + * version 2 of the License, or (at your option) any later version. > >> + * > >> + * This library is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > GNU > >> + * Lesser General Public License for more details. > >> + * > >> + * You should have received a copy of the GNU Lesser General Public > >> + * License along with this library; if not, see > <http://www.gnu.org/licenses/>. > >> + */ > > [...] > >
