Patchew URL: https://patchew.org/QEMU/20200707125356.32450-1-kra...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200707125356.32450-1-kra...@redhat.com Subject: [PATCH v5 00/20] microvm: add acpi support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20200707132116.26207-1-f4...@amsat.org -> patchew/20200707132116.26207-1-f4...@amsat.org Switched to a new branch 'test' d5b6102 tests/acpi: update expected data files for microvm 4016e67 tests/acpi: add microvm test 7a0b05e tests/acpi: allow override blkdev 9855e16 tests/acpi: allow microvm test data updates. e96b4cf microvm: wire up hotplug c0f5744 x86: move cpu plug from pc to x86 d7dc51c x86: move acpi_dev from pc/microvm c98bafc x86: constify x86_machine_is_*_enabled 9bf3547 microvm/acpi: disable virtio-mmio cmdline hack c725465 microvm/acpi: use seabios with acpi=on 856eae6 microvm/acpi: use GSI 16-23 for virtio 4b04f91 microvm/acpi: add acpi_dsdt_add_virtio() for x86 1d5e0bf microvm/acpi: add minimal acpi support 6ec826e microvm: make virtio irq base runtime configurable c3ca775 acpi: move acpi_dsdt_add_power_button() to ged 7d7d83c acpi: ged: add x86 device variant. 18cd04d acpi: ged: add control regs c64763a seabios: add bios-microvm.bin binary 91801f8 seabios: add microvm config, update build rules 31f51e5 microvm: name qboot binary qboot.rom === OUTPUT BEGIN === 1/20 Checking commit 31f51e53edea (microvm: name qboot binary qboot.rom) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: rename from pc-bios/bios-microvm.bin total: 0 errors, 1 warnings, 35 lines checked Patch 1/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/20 Checking commit 91801f804550 (seabios: add microvm config, update build rules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 39 lines checked Patch 2/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/20 Checking commit c64763a56c6a (seabios: add bios-microvm.bin binary) 4/20 Checking commit 18cd04d78b56 (acpi: ged: add control regs) 5/20 Checking commit 7d7d83cd1c2c (acpi: ged: add x86 device variant.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 51 lines checked Patch 5/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/20 Checking commit c3ca775f6e35 (acpi: move acpi_dsdt_add_power_button() to ged) 7/20 Checking commit 6ec826ec31e9 (microvm: make virtio irq base runtime configurable) 8/20 Checking commit 1d5e0bff7fc1 (microvm/acpi: add minimal acpi support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #39: FILE: hw/i386/acpi-microvm.c:1: +/* Support for generating ACPI tables and passing them to Guests WARNING: Block comments use a leading /* on a separate line #163: FILE: hw/i386/acpi-microvm.c:125: + table_offsets = g_array_new(false, true /* clear */, WARNING: Block comments use a leading /* on a separate line #167: FILE: hw/i386/acpi-microvm.c:129: + 64 /* Ensure FACS is aligned */, WARNING: Block comments use a leading /* on a separate line #168: FILE: hw/i386/acpi-microvm.c:130: + false /* high memory */); total: 0 errors, 5 warnings, 311 lines checked Patch 8/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/20 Checking commit 4b04f911df7a (microvm/acpi: add acpi_dsdt_add_virtio() for x86) 10/20 Checking commit 856eae6a8af7 (microvm/acpi: use GSI 16-23 for virtio) 11/20 Checking commit c7254650d200 (microvm/acpi: use seabios with acpi=on) 12/20 Checking commit 9bf3547b321c (microvm/acpi: disable virtio-mmio cmdline hack) 13/20 Checking commit c98bafce4745 (x86: constify x86_machine_is_*_enabled) 14/20 Checking commit d7dc51c13d40 (x86: move acpi_dev from pc/microvm) 15/20 Checking commit c0f57441ad6c (x86: move cpu plug from pc to x86) ERROR: space required before the open parenthesis '(' #344: FILE: hw/i386/x86.c:187: + if(!object_dynamic_cast(OBJECT(cpu), ms->cpu_type)) { WARNING: Block comments use a leading /* on a separate line #431: FILE: hw/i386/x86.c:274: + /* if 'address' properties socket-id/core-id/thread-id are not set, set them WARNING: Block comments use a leading /* on a separate line #434: FILE: hw/i386/x86.c:277: + /* TODO: move socket_id/core_id/thread_id checks into x86_cpu_realizefn() WARNING: Block comments use a trailing */ on a separate line #436: FILE: hw/i386/x86.c:279: + * CPUState::nr_cores and CPUState::nr_threads fields instead of globals */ WARNING: Block comments use a leading /* on a separate line #484: FILE: hw/i386/x86.c:327: + /* If the number of CPUs can't be represented in 8 bits, the WARNING: Block comments use a leading /* on a separate line #502: FILE: hw/i386/x86.c:345: +/* returns pointer to CPUArchId descriptor that matches CPU's apic_id total: 1 errors, 5 warnings, 533 lines checked Patch 15/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/20 Checking commit e96b4cfdddca (microvm: wire up hotplug) 17/20 Checking commit 9855e16bac52 (tests/acpi: allow microvm test data updates.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 4 lines checked Patch 17/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/20 Checking commit 7a0b05e95471 (tests/acpi: allow override blkdev) 19/20 Checking commit 4016e6747755 (tests/acpi: add microvm test) 20/20 Checking commit d5b610245ac6 (tests/acpi: update expected data files for microvm) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200707125356.32450-1-kra...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
