On Sat, Jun 27, 2020 at 10:09:22AM -0700, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva <elena.ufimts...@oracle.com> > > This is the v7 of the patchset.
I have completed the review and left comments on the patches. I'm glad it was possible to simplify this feature. The overall approach makes sense to me and I see how it forms the base on which VFIO-over-socket and smaller remote program builds using Kconfig can be developed. My main concern is that the object lifecycle has not been fully implemented in the proxy and remote device. Error handling is incomplete, resources are leaked, and hot unplug does not work. Thinking through the lifecycle is very important so that additional work can build on top of this later. I have tried to point out these issues in the individual patches.
signature.asc
Description: PGP signature
