On Thu, Jul 02, 2020 at 11:16:03AM +0100, Peter Maydell wrote: > On Thu, 2 Jul 2020 at 10:53, Michael S. Tsirkin <m...@redhat.com> wrote: > > > > On Mon, Jun 29, 2020 at 04:09:37PM +0200, Andrew Jones wrote: > > > The flash device is exclusively for the host-controlled firmware, so > > > we should not expose it to the OS. Exposing it risks the OS messing > > > with it, which could break firmware runtime services and surprise the > > > OS when all its changes disappear after reboot. > > > > > > As firmware needs the device and uses DT, we leave the device exposed > > > there. It's up to firmware to remove the nodes from DT before sending > > > it on to the OS. However, there's no need to force firmware to remove > > > tables from ACPI (which it doesn't know how to do anyway), so we > > > simply don't add the tables in the first place. But, as we've been > > > adding the tables for quite some time and don't want to change the > > > default hardware exposed to versioned machines, then we only stop > > > exposing the flash device tables for 5.1 and later machine types. > > > > > > Suggested-by: Ard Biesheuvel <ard.biesheu...@arm.com> > > > Suggested-by: Laszlo Ersek <ler...@redhat.com> > > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > > > So who's merging this? Mostly ACPI things so I guess my tree? > > If so can I get acks from ARM maintainers pls? > > This is on my to-look-at queue but in theory I'm on holiday this week :-) > > -- PMM
I picked up patch 1 for now :) -- MST
