On 6/29/20 2:07 PM, Peter Maydell wrote: > On Mon, 29 Jun 2020 at 09:29, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: >> >> On 6/28/20 4:24 PM, Peter Maydell wrote: >>> Create a header file for the hw/misc/max111x device, in the >>> usual modern style for QOM devices: >>> * definition of the TYPE_ constants and macros >>> * definition of the device's state struct so that it can >>> be embedded in other structs if desired
Ah, fine. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> >>> * documentation of the interface >>> >>> This allows us to use TYPE_MAX_1111 in the spitz.c code rather >>> than the string "max1111". >>> >>> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >>> --- > >> Nitpick, we can keep MAX_111X() + MAX111xState in "hw/misc/max111x.c" >> until we get a consumer. > > This is deliberate, as noted in the commit message. > > thanks > -- PMM >
