Patchew URL: https://patchew.org/QEMU/20200628142429.17111-1-peter.mayd...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/17] spitz: fix hacks, fix CID 1421913, various cleanups Type: series Message-id: 20200628142429.17111-1-peter.mayd...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu 553cf5d..e765115 master -> master From https://github.com/patchew-project/qemu * [new tag] patchew/20200628142429.17111-1-peter.mayd...@linaro.org -> patchew/20200628142429.17111-1-peter.mayd...@linaro.org Switched to a new branch 'test' 108665c Replace uses of FROM_SSI_SLAVE() macro with QOM casts 6c99757 hw/arm/spitz: Provide usual QOM macros for corgi-ssp and spitz-lcdtg 98348e5 hw/arm/pxa2xx_pic: Use LOG_GUEST_ERROR for bad guest register accesses 0c5e2a2 hw/arm/spitz: Use LOG_GUEST_ERROR for bad guest register accesses 7856c52 hw/gpio/zaurus.c: Use LOG_GUEST_ERROR for bad guest register accesses 45b5766 hw/arm/spitz: Encapsulate misc GPIO handling in a device 7c67922 hw/misc/max111x: Create header file for documentation, TYPE_ macros 952c610 hw/misc/max111x: Use GPIO lines rather than max111x_set_input() 8febdff hw/arm/spitz: Use max111x properties to set initial values 9a1ed3c ssi: Add ssi_realize_and_unref() efa4918 hw/misc/max111x: Don't use vmstate_register() ccc835d hw/misc/max111x: provide QOM properties for setting initial values 9e5c852 hw/arm/spitz: Implement inbound GPIO lines for bit5 and power signals 0ec3ef7 hw/arm/spitz: Keep pointers to scp0, scp1 in SpitzMachineState 7be6379 hw/arm/spitz: Keep pointers to MPU and SSI devices in SpitzMachineState 8059a4e hw/arm/spitz: Create SpitzMachineClass abstract base class 736d97f hw/arm/spitz: Detabify === OUTPUT BEGIN === 1/17 Checking commit 736d97fd84fb (hw/arm/spitz: Detabify) ERROR: space prohibited before that '++' (ctx:WxB) #110: FILE: hw/arm/spitz.c:303: +#define QUEUE_KEY(c) s->fifo[(s->fifopos + s->fifolen ++) & 0xf] = c ^ ERROR: Macros with complex values should be enclosed in parenthesis #110: FILE: hw/arm/spitz.c:303: +#define QUEUE_KEY(c) s->fifo[(s->fifopos + s->fifolen ++) & 0xf] = c total: 2 errors, 0 warnings, 259 lines checked Patch 1/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/17 Checking commit 8059a4e54d2b (hw/arm/spitz: Create SpitzMachineClass abstract base class) 3/17 Checking commit 7be6379c8f45 (hw/arm/spitz: Keep pointers to MPU and SSI devices in SpitzMachineState) 4/17 Checking commit 0ec3ef7a8701 (hw/arm/spitz: Keep pointers to scp0, scp1 in SpitzMachineState) 5/17 Checking commit 9e5c852ff9ad (hw/arm/spitz: Implement inbound GPIO lines for bit5 and power signals) WARNING: line over 80 characters #94: FILE: hw/arm/spitz.c:859: + qdev_get_gpio_in_named(sms->lcdtg, "bl_power", 0)); total: 0 errors, 1 warnings, 68 lines checked Patch 5/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/17 Checking commit ccc835da8b9e (hw/misc/max111x: provide QOM properties for setting initial values) 7/17 Checking commit efa4918480f8 (hw/misc/max111x: Don't use vmstate_register()) 8/17 Checking commit 9a1ed3c4a634 (ssi: Add ssi_realize_and_unref()) 9/17 Checking commit 8febdffc3c42 (hw/arm/spitz: Use max111x properties to set initial values) WARNING: Block comments use a leading /* on a separate line #29: FILE: hw/arm/spitz.c:736: + qdev_prop_set_uint8(sms->max1111, "input1" /* BATT_VOLT */, WARNING: Block comments use a leading /* on a separate line #31: FILE: hw/arm/spitz.c:738: + qdev_prop_set_uint8(sms->max1111, "input2" /* BATT_TEMP */, 0); WARNING: Block comments use a leading /* on a separate line #32: FILE: hw/arm/spitz.c:739: + qdev_prop_set_uint8(sms->max1111, "input3" /* ACIN_VOLT */, total: 0 errors, 3 warnings, 18 lines checked Patch 9/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/17 Checking commit 952c610248da (hw/misc/max111x: Use GPIO lines rather than max111x_set_input()) 11/17 Checking commit 7c6792207add (hw/misc/max111x: Create header file for documentation, TYPE_ macros) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #94: new file mode 100644 total: 0 errors, 1 warnings, 114 lines checked Patch 11/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/17 Checking commit 45b57669dce5 (hw/arm/spitz: Encapsulate misc GPIO handling in a device) WARNING: line over 80 characters #183: FILE: hw/arm/spitz.c:893: + qdev_get_gpio_in(sms->max1111, MAX1111_BATT_TEMP)); total: 0 errors, 1 warnings, 185 lines checked Patch 12/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/17 Checking commit 7856c52c4f9e (hw/gpio/zaurus.c: Use LOG_GUEST_ERROR for bad guest register accesses) 14/17 Checking commit 0c5e2a25d7ce (hw/arm/spitz: Use LOG_GUEST_ERROR for bad guest register accesses) 15/17 Checking commit 98348e514804 (hw/arm/pxa2xx_pic: Use LOG_GUEST_ERROR for bad guest register accesses) 16/17 Checking commit 6c9975774bb7 (hw/arm/spitz: Provide usual QOM macros for corgi-ssp and spitz-lcdtg) 17/17 Checking commit 108665c37c6d (Replace uses of FROM_SSI_SLAVE() macro with QOM casts) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200628142429.17111-1-peter.mayd...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
