On Thu, 25 Jun 2020 at 22:31, David CARLIER <devne...@gmail.com> wrote: > > From 78706a28c6aa8b5e522b5781588b38961d79d6f6 Mon Sep 17 00:00:00 2001 > From: David Carlier <devne...@gmail.com> > Date: Thu, 25 Jun 2020 19:32:42 +0000 > Subject: [PATCH] build: haiku system build fix > > Most of missing features resides in the bsd library. > Also defining constant equivalence. > > Signed-off-by: David Carlier <devne...@gmail.com> > --- > configure | 34 ++++++++++++++++++++++++++++++++-- > include/qemu/bswap.h | 2 ++ > include/qemu/osdep.h | 4 ++++ > os-posix.c | 4 ++++ > util/Makefile.objs | 2 +- > util/compatfd.c | 2 ++ > util/main-loop.c | 1 + > util/oslib-posix.c | 20 ++++++++++++++++++++ > util/qemu-openpty.c | 2 +- > 9 files changed, 67 insertions(+), 4 deletions(-)
Would you mind splitting this into a patchset which has one patch for each fix, please? So a patch which makes configure probe for openpty-in-pty.h and use it, another patch for the mlockall change, another patch for haiku-implementation-of-qemu_init_exec_dir, and so on. We generally prefer each commit to do one thing; it's easier to review. thanks -- PMM