On 6/24/20 11:43 AM, Markus Armbruster wrote:
When creating an image fails because the format doesn't support option "backing_file" or "backing_fmt", bdrv_img_create() first has qemu_opt_set() put a generic error into @local_err, then puts the real error into @errp with error_setg(), and then propagates the former to the latter, which throws away the generic error. A bit complicated, but works.
Hmm - may interact with my series to deprecate -b without -F. We'll deal with the fallout based on whatever lands first.
Not that qemu_opt_set() returns a useful value, we can simply ignore
s/Not/Now/
the generic error instead. Signed-off-by: Markus Armbruster <arm...@redhat.com> --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Aha - you fixed 2 of the 4 cases that I noticed in 17/46. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
