On Wed, Jun 24, 2020 at 10:37:19AM +0200, Markus Armbruster wrote: > spapr_machine_init() leaks an Error object when > kvmppc_check_papr_resize_hpt() fails and spapr->resize_hpt is > SPAPR_RESIZE_HPT_DISABLED, i.e. when the host doesn't support hash > page table resizing, and the user didn't ask for it. As harmless as > memory leaks can possibly be. Plug it. > > Fixes: 30f4b05bd090564181554d0890605eb2c143e4ea > Cc: David Gibson <dgib...@redhat.com> > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster <arm...@redhat.com>
Acked-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
> hw/ppc/spapr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index bd9345cdac..9bd2183ead 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2731,6 +2731,7 @@ static void spapr_machine_init(MachineState *machine)
> error_report_err(resize_hpt_err);
> exit(1);
> }
> + error_free(resize_hpt_err);
>
> spapr->rma_size = spapr_rma_size(spapr, &error_fatal);
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
