This series addresses a number of error handling issues I found while working on error handling improvements. It's based on my "[PULL 00/16] Qdev patches for 2020-06-23" merged into current master.
Based-on: <20200623142326.2349416-1-arm...@redhat.com> v2: * PATCH 04: Two more instances, in tests/check-qom-proplist * PATCH 12: Dropped; PATCH 04 takes care of it * PATCH 17: One more instance due to rebase; R-by kept * PATCH 22-25: New Markus Armbruster (25): net/virtio: Fix failover_replug_primary() return value regression pci: Delete useless error_propagate() Clean up some calls to ignore Error objects the right way tests: Use &error_abort where appropriate tests: Use error_free_or_abort() where appropriate usb/dev-mtp: Fix Error double free after inotify failure spapr: Plug minor memory leak in spapr_machine_init() qga: Plug unlikely memory leak in guest-set-memory-blocks sd/milkymist-memcard: Plug minor memory leak in realize test-util-filemonitor: Plug unlikely memory leak vnc: Plug minor memory leak in vnc_display_open() aspeed: Clean up roundabout error propagation qdev: Drop qbus_set_bus_hotplug_handler() parameter @errp qdev: Drop qbus_set_hotplug_handler() parameter @errp hw: Fix error API violation around object_property_set_link() hw/arm: Drop useless object_property_set_link() error handling riscv/sifive_u: Fix sifive_u_soc_realize() error API violations riscv_hart: Fix riscv_harts_realize() error API violations mips/cps: Fix mips_cps_realize() error API violations x86: Fix x86_cpu_new() error API violations amd_iommu: Fix amdvi_realize() error API violation arm/stm32f205 arm/stm32f405: Fix realize error API violation aspeed: Fix realize error API violation hw/arm/armsse: Fix armsse_realize() error API violation arm/{bcm2835,fsl-imx25,fsl-imx6}: Fix realize error API violations include/hw/qdev-core.h | 5 +- chardev/char-socket.c | 6 +- hw/9pfs/9p.c | 6 +- hw/acpi/pcihp.c | 3 +- hw/acpi/piix4.c | 2 +- hw/arm/armsse.c | 61 +++++----------- hw/arm/armv7m.c | 7 +- hw/arm/aspeed_ast2600.c | 35 ++++----- hw/arm/aspeed_soc.c | 29 +++----- hw/arm/bcm2835_peripherals.c | 12 ++-- hw/arm/fsl-imx25.c | 12 ++-- hw/arm/fsl-imx6.c | 12 ++-- hw/arm/nrf51_soc.c | 6 +- hw/arm/stm32f205_soc.c | 2 +- hw/arm/stm32f405_soc.c | 2 +- hw/arm/virt.c | 4 +- hw/char/virtio-serial-bus.c | 4 +- hw/core/bus.c | 8 +-- hw/display/virtio-gpu-pci.c | 2 +- hw/display/virtio-vga.c | 2 +- hw/dma/sparc32_dma.c | 6 +- hw/dma/xilinx_axidma.c | 12 +--- hw/i386/amd_iommu.c | 6 +- hw/i386/x86.c | 12 +--- hw/mips/cps.c | 35 +++++---- hw/misc/macio/macio.c | 3 +- hw/net/virtio-net.c | 2 +- hw/net/xilinx_axienet.c | 12 +--- hw/pci/pci.c | 3 - hw/pci/pcie.c | 2 +- hw/pci/shpc.c | 2 +- hw/ppc/spapr.c | 4 +- hw/ppc/spapr_drc.c | 4 +- hw/ppc/spapr_pci.c | 4 +- hw/riscv/riscv_hart.c | 14 ++-- hw/riscv/sifive_u.c | 12 +++- hw/s390x/ap-bridge.c | 2 +- hw/s390x/css-bridge.c | 2 +- hw/s390x/s390-pci-bus.c | 14 +--- hw/scsi/scsi-bus.c | 2 +- hw/scsi/virtio-scsi.c | 4 +- hw/scsi/vmw_pvscsi.c | 2 +- hw/sd/milkymist-memcard.c | 5 +- hw/usb/bus.c | 2 +- hw/usb/dev-mtp.c | 2 - hw/usb/dev-smartcard-reader.c | 2 +- hw/virtio/virtio-iommu-pci.c | 2 +- hw/xen/xen-bus.c | 2 +- hw/xen/xen-legacy-backend.c | 2 +- qga/commands-posix.c | 1 + tests/check-block-qdict.c | 24 ++----- tests/check-qobject.c | 5 +- tests/check-qom-proplist.c | 14 ++-- tests/test-base64.c | 3 +- tests/test-bdrv-graph-mod.c | 4 +- tests/test-block-iothread.c | 3 +- tests/test-crypto-cipher.c | 8 +-- tests/test-io-task.c | 4 +- tests/test-logging.c | 12 +--- tests/test-qemu-opts.c | 22 ++---- tests/test-replication.c | 109 +++++++++-------------------- tests/test-string-input-visitor.c | 33 +++------ tests/test-string-output-visitor.c | 16 ++--- tests/test-util-filemonitor.c | 1 + ui/vnc.c | 6 +- 65 files changed, 229 insertions(+), 432 deletions(-) -- 2.26.2