On 6/16/20 12:27 PM, Peter Maydell wrote: > On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: >> >> The FPGA system control block has 2 push-buttons labelled PB0/PB1. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> --- > >> @@ -249,6 +258,8 @@ static void mps2_fpgaio_init(Object *obj) >> memory_region_init_io(&s->iomem, obj, &mps2_fpgaio_ops, s, >> "mps2-fpgaio", 0x1000); >> sysbus_init_mmio(sbd, &s->iomem); >> + >> + qdev_init_gpio_in_named(DEVICE(s), mps2_fpgaio_push_button, "PB", 2); >> } > > This change seems kind of pointless unless these GPIO lines are > actually wired up to something.
Yes, I should have kept it out of this series, or documented better the goal in the cover. I'm setting the roots to motivate a team of developers to work on a visualization of the MPS2 board. The push-button is supported by Zephyr, so the the idea is the visualizer generates QMP GPIO event to be processed such in pca9552_set_led(), and interact with the guest firmware. > > thanks > -- PMM >
