On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > The FPGA system control block has 2 push-buttons labelled PB0/PB1. > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > ---
> @@ -249,6 +258,8 @@ static void mps2_fpgaio_init(Object *obj) > memory_region_init_io(&s->iomem, obj, &mps2_fpgaio_ops, s, > "mps2-fpgaio", 0x1000); > sysbus_init_mmio(sbd, &s->iomem); > + > + qdev_init_gpio_in_named(DEVICE(s), mps2_fpgaio_push_button, "PB", 2); > } This change seems kind of pointless unless these GPIO lines are actually wired up to something. thanks -- PMM
