On Wed, Jul 20, 2011 at 12:25:37PM +0200, Gerd Hoffmann wrote:
> Make sure at least one port (port=.. or tls-port=...)
> is specified. Also apply range checks to the port numbers.
>
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
ACK.
> ---
> ui/spice-core.c | 11 ++++++++++-
> 1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index e142452..1100417 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -480,7 +480,16 @@ void qemu_spice_init(void)
> port = qemu_opt_get_number(opts, "port", 0);
> tls_port = qemu_opt_get_number(opts, "tls-port", 0);
> if (!port && !tls_port) {
> - return;
> + fprintf(stderr, "neither port nor tls-port specified for spice.");
> + exit(1);
> + }
> + if (port < 0 || port > 65535) {
> + fprintf(stderr, "spice port is out of range");
> + exit(1);
> + }
> + if (tls_port < 0 || tls_port > 65535) {
> + fprintf(stderr, "spice tls-port is out of range");
> + exit(1);
> }
> password = qemu_opt_get(opts, "password");
>
> --
> 1.7.1
>
>
