Markus Armbruster <arm...@redhat.com> writes:
> David Hildenbrand <da...@redhat.com> writes:
>
>>>> +static void realize_event_facility(DeviceState *dev, Error **errp)
>>>> +{
>>>> + SCLPEventFacility *event_facility = EVENT_FACILITY(dev);
>>>> + Error *local_err = NULL;
>>>> +
>>>> + qdev_realize(DEVICE(&event_facility->quiesce),
>>>> + BUS(&event_facility->sbus), &local_err);
>>>> + if (local_err) {
>>>> + error_propagate(errp, local_err);
>>>> + return;
>>>> + }
>>>> + qdev_realize(DEVICE(&event_facility->cpu_hotplug),
>>>> + BUS(&event_facility->sbus), errp);
>>>
>>> Just wondering, do we have to care about un-realizing quiesce in case
>>> this fails?
>>
>> Just remembered that we fail creating the machine and therefore abort. So
>> not necessary :)
>
> True.
I chose to clean up on error anyway in v2. Thanks!
