On Thu, May 21, 2020 at 09:40:55AM +0800, Robert Hoo wrote: > On Wed, 2020-05-20 at 10:17 +0100, Daniel P. Berrangé wrote: > > On Wed, May 20, 2020 at 10:10:07AM +0800, Chenyi Qiang wrote: > > > There are no Icelake Desktop products in the market. Remove the > > > Icelake-Client CPU model. > > > > QEMU has been shipping this CPU model for 2 years now. Regardless > > of what CPUs Intel are selling, it is possible for users to be > > running VMs with Icelake-Client CPU if their host satisfies the > > listed features. So I don't think it is valid to remove this. > > > This 'Icelake-Client' actually doesn't exist. How do we define its > feature list? and who will be using it? If any special feature tailor > requirement, it can be simply achieved by '-cpu Icelake,+/-' features, > this is the correct way.
Well its feature list is defined by what exists in QEMU code right now. Presumably was based off some silicon that did exist in Intel at some point, or it would not have been added to QEMU in the first place ? Changing guests to use "-cpu Icelake-Server,+/-" would be a guest ABI change because of the different model number IIUC > I think we should remove it. When we realize something's not correct, > we should fix it ASAP. Leaving it there will only cause more serious > issue in the future. We have versioned CPU models so that we can fix mistakes in previously defined CPU model features, without causing breakage for anything that is using the previous incorrectly defined model. We can't version the deletion of a CPU model though. I'm not seeing the serious harm that's caused by the Icelake-Client CPU model existing though, and deleting it will definitely cause harm to the config of anything that currently happens to use it. Maybe Icelake-Client could be turned into a deprecated alias for a version of Icelake-Server that has the cutdown feature list ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
