On 07/14/2011 12:05 PM, Michal Novotny wrote:
What do you mean by removing migration.c from the list? Do you mean
doing no modifications to this file?
No usage of the time variables in migration.c.
it's about milliseconds
It's noise anyway.
The arch_init.c to include savevm-related code doesn't make any sense in
general which is the thing I have to agree but if we want to measure the
ram_save_live() per each stage we need to alter the ram_save_live()
function which is present in the arch_init.c file (this is directly in
vl.c file for RHEL-6 version of qemu however for upstream version we
need to modify arch_init.c to provide the most precise RAM transfer
values per each stage). We can move the ram_save_live() function into
some other file, like savevm.c or vl.c... Is this what you mean by "If
you move that code back to savevm.c" ? The code is in vl.c file for
RHEL-6, not savevm.c and I don't know whether it ever was in savevm.c .
I think savevm.c is the right place for it.
Alternatively, what about updating the information for ram and disk
directly in qemu_savevm_state_begin/iterate/complete (and similarly for
loading)? Just change "disk" to "block" so that it matches the
parameter of register_savevm_live in block-migration.c.
Paolo
