On Wed, May 06, 2020 at 04:14:19PM +0200, Igor Mammedov wrote: > On Wed, 6 May 2020 12:35:49 +0200 > Gerd Hoffmann <kra...@redhat.com> wrote: > > > > > +/* FIXME: copy & paste */ > > > > +static void acpi_dsdt_add_power_button(Aml *scope) > > > > +{ > > > > + Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE); > > > > + aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C"))); > > > > + aml_append(dev, aml_name_decl("_UID", aml_int(0))); > > > > + aml_append(scope, dev); > > > > +} > > > > > > could be unified with ARM's version > > > > Yep. Suggestions for a good place? hw/acpi/aml-build.c ? > sounds good to me
Hmm, tried that, but ACPI_POWER_BUTTON_DEVICE is defined in ged header file, so ged.c looks like a better fit ;) take care, Gerd