On Thu, 7 May 2020 01:00:05 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote:
> On 5/6/2020 10:23 PM, Dr. David Alan Gilbert wrote: > > * Cornelia Huck (coh...@redhat.com) wrote: > >> On Wed, 6 May 2020 02:38:46 -0400 > >> Yan Zhao <yan.y.z...@intel.com> wrote: > >> > >>> On Tue, May 05, 2020 at 12:37:26PM +0800, Alex Williamson wrote: > >>>> It's been a long time, but that doesn't seem like what I was asking. > >>>> The sysfs version checking is used to select a target that is likely to > >>>> succeed, but the migration stream is still generated by a user and the > >>>> vendor driver is still ultimately responsible for validating that > >>>> stream. I would hope that a vendor migration stream therefore starts > >>>> with information similar to that found in the sysfs interface, allowing > >>>> the receiving vendor driver to validate the source device and vendor > >>>> software version, such that we can fail an incoming migration that the > >>>> vendor driver deems incompatible. Ideally the vendor driver might also > >>>> include consistency and sequence checking throughout the stream to > >>>> prevent a malicious user from exploiting the internal operation of the > >>>> vendor driver. Thanks, > >> > >> Some kind of somewhat standardized marker for driver/version seems like > >> a good idea. Further checking is also a good idea, but I think the > >> details of that need to be left to the individual drivers. > > > > Standardised markers like that would be useful; although the rules of > > how to compare them might be a bit vendor specific; but still - it would > > be good for us to be able to dump something out when it all goes wrong. > > > > Such checking should already there in vendor driver. Vendor driver might > also support across version migration. I think checking in QEMU again > would be redundant. Let vendor driver handle version checks. Of course the actual rules of what is supported and what not are vendor driver specific -- but we can still benefit from some standardization. It ensures that this checking is not forgotten, and it can help with figuring out what went wrong.
