Patchew URL: https://patchew.org/QEMU/20200505152926.18877-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200505152926.18877-1-arm...@redhat.com Subject: [PATCH v2 00/18] qom: Spring cleaning Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20200505230941.3984108-1-alistair.fran...@wdc.com -> patchew/20200505230941.3984108-1-alistair.fran...@wdc.com Switched to a new branch 'test' 258378d qom: Drop @errp parameter of object_property_del() ae7803d spapr_pci: Drop some dead error handling 3867341 qdev: Unrealize must not fail 27ab964 Drop more @errp parameters after previous commit 051ab01 qom: Drop parameter @errp of object_property_add() & friends d9987b4 qdev: Clean up qdev_connect_gpio_out_named() 4ac9492 hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory 576bcc1 e1000: Don't run e1000_instance_init() twice 1e343fb hw/isa/superio: Make the components QOM children 2546372 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256 9feee4e tests/check-qom-proplist: Improve iterator coverage e3f4e24 qom: Drop object_property_set_description() parameter @errp 2235c72 qom: Make all the object_property_add_FOO() return the property 4a961f6 qom: Drop convenience method object_property_get_uint16List() a4ffec8 qom: Simplify object_property_get_enum() 30ca898 qom: Drop object_property_del_child()'s unused parameter @errp 77d819a qom: Clean up inconsistent use of gchar * vs. char * 96209f3 qom: Clearer reference counting in object_initialize_childv() === OUTPUT BEGIN === 1/18 Checking commit 96209f39f167 (qom: Clearer reference counting in object_initialize_childv()) 2/18 Checking commit 77d819acbc03 (qom: Clean up inconsistent use of gchar * vs. char *) 3/18 Checking commit 30ca898bb7dc (qom: Drop object_property_del_child()'s unused parameter @errp) 4/18 Checking commit a4ffec863b8d (qom: Simplify object_property_get_enum()) 5/18 Checking commit 4a961f67af22 (qom: Drop convenience method object_property_get_uint16List()) 6/18 Checking commit 2235c72d45a6 (qom: Make all the object_property_add_FOO() return the property) 7/18 Checking commit e3f4e24ddb2e (qom: Drop object_property_set_description() parameter @errp) 8/18 Checking commit 9feee4e3da40 (tests/check-qom-proplist: Improve iterator coverage) 9/18 Checking commit 2546372e6e85 (s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256) ERROR: line over 90 characters #53: FILE: target/s390x/cpu_features_def.inc.h:314: +DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC Compute-Last-Block-CMAC-Using-AES-256") total: 1 errors, 0 warnings, 8 lines checked Patch 9/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/18 Checking commit 1e343fbe99af (hw/isa/superio: Make the components QOM children) 11/18 Checking commit 576bcc126dca (e1000: Don't run e1000_instance_init() twice) 12/18 Checking commit 4ac949293617 (hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory) 13/18 Checking commit d9987b49f373 (qdev: Clean up qdev_connect_gpio_out_named()) 14/18 Checking commit 051ab01ed5fe (qom: Drop parameter @errp of object_property_add() & friends) WARNING: line over 80 characters #209: FILE: backends/hostmem-file.c:187: + file_memory_backend_get_discard_data, file_memory_backend_set_discard_data); WARNING: line over 80 characters #1080: FILE: hw/arm/raspi.c:287: + object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(machine->ram)); WARNING: line over 80 characters #3095: FILE: hw/ppc/spapr.c:3346: + &spapr->kernel_addr, OBJ_PROP_FLAG_READWRITE); total: 0 errors, 3 warnings, 4471 lines checked Patch 14/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/18 Checking commit 27ab9642f5b9 (Drop more @errp parameters after previous commit) 16/18 Checking commit 386734149793 (qdev: Unrealize must not fail) 17/18 Checking commit ae7803d737f4 (spapr_pci: Drop some dead error handling) 18/18 Checking commit 258378dd975d (qom: Drop @errp parameter of object_property_del()) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200505152926.18877-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
