On 4/27/20 3:53 AM, Markus Armbruster wrote:
Eric Blake <ebl...@redhat.com> writes:


Although it touches NBD, I'm happy for this to go through your tree
with the larger series.

+++ b/qemu-nbd.c
@@ -856,8 +856,7 @@ int main(int argc, char **argv)
           }
           tlscreds = nbd_get_tls_creds(tlscredsid, list, &local_err);
           if (local_err) {
-            error_report("Failed to get TLS creds %s",
-                         error_get_pretty(local_err));
+            error_reportf_err(local_err, "Failed to get TLS creds ");

Odd one out for not using ':' in the message, but that's independent
of this patch.

The patch is short enough to deviate from "purely mechanical" and stick
in ':' here.  Your choice.

Adding it in now is fine by me.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


Reply via email to