Hi On Wed, Apr 15, 2020 at 3:00 AM Adalbert Lazăr <ala...@bitdefender.com> wrote: > > qmp_chardev_open_socket() ignores the absence of the 'server' argument > and always switches to listen/server mode. > > CC: "Marc-André Lureau" <marcandre.lur...@redhat.com> > CC: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Adalbert Lazăr <ala...@bitdefender.com> > --- > chardev/char-socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > index 9b2deb0125..fd0106ab85 100644 > --- a/chardev/char-socket.c > +++ b/chardev/char-socket.c > @@ -1310,7 +1310,7 @@ static void qmp_chardev_open_socket(Chardev *chr, > SocketChardev *s = SOCKET_CHARDEV(chr); > ChardevSocket *sock = backend->u.socket.data; > bool do_nodelay = sock->has_nodelay ? sock->nodelay : false; > - bool is_listen = sock->has_server ? sock->server : true; > + bool is_listen = sock->has_server ? sock->server : false;
I don't understand what you mean. It defaults to server mode. We can't change that. > bool is_telnet = sock->has_telnet ? sock->telnet : false; > bool is_tn3270 = sock->has_tn3270 ? sock->tn3270 : false; > bool is_waitconnect = sock->has_wait ? sock->wait : false; > -- Marc-André Lureau
