Patchew URL: https://patchew.org/QEMU/20200415055140.466900-1-...@irrelevant.dk/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v7 00/48] nvme: support NVMe v1.3d, SGLs and multiple namespaces Message-id: 20200415055140.466900-1-...@irrelevant.dk Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20200415055140.466900-1-...@irrelevant.dk -> patchew/20200415055140.466900-1-...@irrelevant.dk Switched to a new branch 'test' 075a008 nvme: make lba data size configurable 47f0589 nvme: change controller pci id d5526c6 pci: allocate pci id for nvme c945ecc nvme: support multiple namespaces 88ff4af nvme: refactor identify active namespace id list 05eb730 nvme: add support for sgl bit bucket descriptor ccd3495 nvme: add support for scatter gather lists 525413d nvme: harden cmb access c893248 nvme: handle dma errors a1dcb81 pci: pass along the return value of dma_memory_rw 68e505d nvme: use preallocated qsg/iov in nvme_dma_prp 5778b7c nvme: add nvme_check_rw helper bddb627 nvme: allow multiple aios per command 450162a nvme: remove NvmeCmd parameter 5b8060c nvme: refactor NvmeRequest a4c50e4 nvme: be consistent about zeros vs zeroes d60e3c2 nvme: add check for mdts 465e28d nvme: refactor request bounds checking 34b728f nvme: verify validity of prp lists in the cmb c944bc7 nvme: add request mapping helper 29cf5ab nvme: pass request along for tracing dfeb326 nvme: refactor dma read/write be63c8d nvme: remove redundant has_sg member 31c0f74 nvme: replace dma_acct with blk_acct equivalent c237462 nvme: add mapping helpers 5edac1b nvme: memset preallocated requests structures a715b8e nvme: bump supported version to v1.3 1c57d98 nvme: provide the mandatory subnqn field 67a5dd5 nvme: enforce valid queue creation sequence 2e97095 nvme: support identify namespace descriptor list 057a489 nvme: add log specific field to trace events 65f95e3 nvme: make sure ncqr and nsqr is valid 3311059 nvme: additional tracing 3b35916 nvme: add missing mandatory features 9afe18e nvme: add support for the asynchronous event request command 642509b nvme: add support for the get log page command d97b33d nvme: add temperature threshold feature c6ca9fc nvme: refactor device realization 2786713 nvme: remove redundant cmbloc/cmbsz members d9de9d6 nvme: add max_ioqpairs device parameter 5407887 nvme: fix pci doorbell size calculation fc4bdcc nvme: add support for the abort command a80e981 nvme: refactor nvme_addr_read 141dde9 nvme: use constants in identify 0d293d8 nvme: bump spec data structures to v1.3 d102a99 nvme: move device parameters to separate struct 21a7d88 nvme: remove superfluous breaks e3e06ce nvme: rename trace events to nvme_dev === OUTPUT BEGIN === 1/48 Checking commit e3e06ce2a1c6 (nvme: rename trace events to nvme_dev) 2/48 Checking commit 21a7d885cf07 (nvme: remove superfluous breaks) 3/48 Checking commit d102a99b902c (nvme: move device parameters to separate struct) ERROR: Macros with complex values should be enclosed in parenthesis #180: FILE: hw/block/nvme.h:6: +#define DEFINE_NVME_PROPERTIES(_state, _props) \ + DEFINE_PROP_STRING("serial", _state, _props.serial), \ + DEFINE_PROP_UINT32("cmb_size_mb", _state, _props.cmb_size_mb, 0), \ + DEFINE_PROP_UINT32("num_queues", _state, _props.num_queues, 64) total: 1 errors, 0 warnings, 181 lines checked Patch 3/48 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/48 Checking commit 0d293d85aad5 (nvme: bump spec data structures to v1.3) 5/48 Checking commit 141dde95470b (nvme: use constants in identify) 6/48 Checking commit a80e981b44f5 (nvme: refactor nvme_addr_read) 7/48 Checking commit fc4bdcc8d99b (nvme: add support for the abort command) 8/48 Checking commit 5407887ccd40 (nvme: fix pci doorbell size calculation) 9/48 Checking commit d9de9d6bea9b (nvme: add max_ioqpairs device parameter) 10/48 Checking commit 27867136760a (nvme: remove redundant cmbloc/cmbsz members) 11/48 Checking commit c6ca9fc771c8 (nvme: refactor device realization) 12/48 Checking commit d97b33d714fd (nvme: add temperature threshold feature) 13/48 Checking commit 642509b88fa2 (nvme: add support for the get log page command) 14/48 Checking commit 9afe18e6c92e (nvme: add support for the asynchronous event request command) 15/48 Checking commit 3b359168c402 (nvme: add missing mandatory features) 16/48 Checking commit 3311059a2d10 (nvme: additional tracing) 17/48 Checking commit 65f95e32eac2 (nvme: make sure ncqr and nsqr is valid) 18/48 Checking commit 057a489e82f5 (nvme: add log specific field to trace events) 19/48 Checking commit 2e970952379b (nvme: support identify namespace descriptor list) 20/48 Checking commit 67a5dd510a3c (nvme: enforce valid queue creation sequence) 21/48 Checking commit 1c57d98f9cd3 (nvme: provide the mandatory subnqn field) 22/48 Checking commit a715b8ebca1b (nvme: bump supported version to v1.3) 23/48 Checking commit 5edac1bbd208 (nvme: memset preallocated requests structures) 24/48 Checking commit c237462ada4c (nvme: add mapping helpers) 25/48 Checking commit 31c0f741a2d9 (nvme: replace dma_acct with blk_acct equivalent) 26/48 Checking commit be63c8de71b9 (nvme: remove redundant has_sg member) 27/48 Checking commit dfeb3263df77 (nvme: refactor dma read/write) 28/48 Checking commit 29cf5ab19b8e (nvme: pass request along for tracing) 29/48 Checking commit c944bc709579 (nvme: add request mapping helper) 30/48 Checking commit 34b728fd35d6 (nvme: verify validity of prp lists in the cmb) 31/48 Checking commit 465e28dd32a2 (nvme: refactor request bounds checking) 32/48 Checking commit d60e3c234634 (nvme: add check for mdts) 33/48 Checking commit a4c50e475f1d (nvme: be consistent about zeros vs zeroes) 34/48 Checking commit 5b8060cc19a7 (nvme: refactor NvmeRequest) 35/48 Checking commit 450162a9af9e (nvme: remove NvmeCmd parameter) 36/48 Checking commit bddb6275ddec (nvme: allow multiple aios per command) 37/48 Checking commit 5778b7c92f9a (nvme: add nvme_check_rw helper) 38/48 Checking commit 68e505d6710c (nvme: use preallocated qsg/iov in nvme_dma_prp) 39/48 Checking commit a1dcb81b1fc4 (pci: pass along the return value of dma_memory_rw) 40/48 Checking commit c8932482ab54 (nvme: handle dma errors) 41/48 Checking commit 525413d1e0af (nvme: harden cmb access) 42/48 Checking commit ccd349591856 (nvme: add support for scatter gather lists) 43/48 Checking commit 05eb73006c5c (nvme: add support for sgl bit bucket descriptor) 44/48 Checking commit 88ff4af65551 (nvme: refactor identify active namespace id list) 45/48 Checking commit c945ecc719bd (nvme: support multiple namespaces) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #218: FILE: hw/block/nvme-ns.h:8: +#define DEFINE_NVME_NS_PROPERTIES(_state, _props) \ + DEFINE_PROP_DRIVE("drive", _state, blk), \ + DEFINE_PROP_UINT32("nsid", _state, _props.nsid, 0) total: 1 errors, 1 warnings, 841 lines checked Patch 45/48 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 46/48 Checking commit d5526c6f3499 (pci: allocate pci id for nvme) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 46 lines checked Patch 46/48 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 47/48 Checking commit 47f0589e3647 (nvme: change controller pci id) 48/48 Checking commit 075a008ea8e4 (nvme: make lba data size configurable) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200415055140.466900-1-...@irrelevant.dk/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
