сре, 18. мар 2020. у 17:13 Eduardo Habkost <ehabk...@redhat.com> је написао/ла: > > On Wed, Mar 18, 2020 at 10:59:22AM +0300, Vladimir Sementsov-Ogievskiy wrote: > > 18.03.2020 7:12, no-re...@patchew.org wrote: > > > Patchew URL: > > > https://patchew.org/QEMU/20200318011217.2102748-1-ehabk...@redhat.com/ > > > > > > > > > > > > Hi, > > > > > > This series seems to have some coding style problems. See output below for > > > more information: > > > > > > Subject: [PULL 0/4] Python queue for 5.0 soft freeze > > > Message-id: 20200318011217.2102748-1-ehabk...@redhat.com > > > Type: series > > > > > > === TEST SCRIPT BEGIN === > > > #!/bin/bash > > > git rev-parse base > /dev/null || exit 0 > > > git config --local diff.renamelimit 0 > > > git config --local diff.renames True > > > git config --local diff.algorithm histogram > > > ./scripts/checkpatch.pl --mailback base.. > > > === TEST SCRIPT END === > > > > > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > > > Switched to a new branch 'test' > > > 1b4f6f3 MAINTAINERS: add simplebench > > > 57b42b6 scripts/simplebench: add example usage of simplebench > > > 99ea4d7 scripts/simplebench: add qemu/bench_block_job.py > > > 196f97d scripts/simplebench: add simplebench.py > > > > > > === OUTPUT BEGIN === > > > 1/4 Checking commit 196f97d8566d (scripts/simplebench: add simplebench.py) > > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > > > #16: > > > new file mode 100644 > > > > > > ERROR: please use python3 interpreter > > > #21: FILE: scripts/simplebench/simplebench.py:1: > > > +#!/usr/bin/env python > > > > Hmm, yes, we need to fix it. > > > > Should I resend? > > > > Just send that as follow up bug fixes. No need to resend the > whole series. >
Vladimir, you can send as follow-up fixes those changes in output format that we both agree are needed for nicer output. Thanks, Aleksandar > -- > Eduardo > >
