Re: [PATCH 1/9] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler

[Philippe Mathieu-Daudé]

On 3/15/20 10:25 PM, Richard Henderson wrote:
On 3/13/20 11:45 AM, Philippe Mathieu-Daudé wrote:
+        if (qemu_strtol(str + pos, &p, 16, &val) < 0 || val > 0xff) {
+            goto inval;
+        }

This is doing more that *just* using qemu_strtol, it's also validating the
input.  I don't think you need to adjust the patch, just improve the commit
message.  With that,

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

Correct. I'll add a comment, as currently we ignore incorrect input due 
to the implicit cast to uint8_t:

struct MACAddr {
    uint8_t a[6];
};

    mac->a[i] = strtol(str+pos, &p, 16);

Thanks!


r~