Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v31 00/22] Add RX archtecture support Message-id: 20200223065102.61652-1-ys...@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200223065102.61652-1-ys...@users.sourceforge.jp -> patchew/20200223065102.61652-1-ys...@users.sourceforge.jp Switched to a new branch 'test' 433172d qemu-doc.texi: Add RX section. c0c0863 BootLinuxConsoleTest: Test the RX-Virt machine 5dbb5d7 Add rx-softmmu 8bb88da hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core cf49ce3 hw/rx: Honor -accel qtest 32a72b7 hw/rx: RX Target hardware definition eec292e hw/char: RX62N serial communication interface (SCI) 91c1557 hw/timer: RX62N internal timer modules 33e1d07 hw/intc: RX62N interrupt controller (ICUa) ab11fd0 target/rx: Dump bytes for each insn during disassembly 6299441 target/rx: Collect all bytes during disassembly d3c39ed target/rx: Emit all disassembly in one prt() 1f9bc5c target/rx: Use prt_ldmi for XCHG_mr disassembly 1665693 target/rx: Replace operand with prt_ldmi in disassembler 23259ca target/rx: Disassemble rx_index_addr into a string 779d660 target/rx: RX disassembler 4b81352 target/rx: CPU definition 8bc073b target/rx: TCG helper f4c1c7b target/rx: TCG translation cc41d5a hw/registerfields.h: Add 8bit and 16bit register macros 24fee16 qemu/bitops.h: Add extract8 and extract16 2848107 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 2848107d5e5a (MAINTAINERS: Add RX) 2/22 Checking commit 24fee169ad38 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit cc41d5a4ab76 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2495. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit f4c1c7b7c6a6 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 8bc073b2f5ff (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 4b8135204261 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 659 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 779d66082061 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 23259ca25efd (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 166569349e2b (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 1f9bc5c6a4b9 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit d3c39ed17740 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 629944121f05 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit ab11fd0114db (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 33e1d077739a (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 91c1557b1025 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit eec292e10649 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 400 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 32a72b70bf4c (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into WARNING: Block comments use * on subsequent lines #147: FILE: hw/rx/rx-virt.c:92: + /* The kernel image is loaded into + the latter half of the SDRAM space. */ WARNING: Block comments use a trailing */ on a separate line #147: FILE: hw/rx/rx-virt.c:92: + the latter half of the SDRAM space. */ total: 0 errors, 4 warnings, 493 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit cf49ce325d60 (hw/rx: Honor -accel qtest) 19/22 Checking commit 8bb88daa7a4f (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit 5dbb5d789697 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit c0c0863e799d (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 433172d9188b (qemu-doc.texi: Add RX section.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200223065102.61652-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
