All other block jobs already provide a QMP option to control the error handling policy. It's time to add it to commit, too.
Peter, I guess libvirt wants to expose this? Nir, as you would probably assume, this is motivated by the recent finding that VDSM has to preallocate the theoretical maximum for commit operations because QEMU doesn't provide a way to reliably resize the base image dynamically. If you ever want to improve that code, this will enable you to do so from the QEMU side. Kevin Wolf (7): qapi: Document meaning of 'ignore' BlockdevOnError for jobs commit: Remove unused bytes_written commit: Fix argument order for block_job_error_action() commit: Inline commit_populate() commit: Fix is_read for block_job_error_action() commit: Expose on-error option in QMP iotests: Test error handling policies with block-commit qapi/block-core.json | 9 +- block/commit.c | 37 ++--- blockdev.c | 8 +- tests/qemu-iotests/040 | 283 +++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/040.out | 4 +- 5 files changed, 309 insertions(+), 32 deletions(-) -- 2.20.1
