On Wed, 12 Feb 2020 at 06:24, Philippe Mathieu-Daudé <phi...@redhat.com> wrote:
>
> On 2/11/20 6:37 PM, Peter Maydell wrote:
> > @@ -185,7 +185,7 @@ uint32_t vfp_get_fpscr(CPUARMState *env)
> > void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val)
> > {
> > /* When ARMv8.2-FP16 is not supported, FZ16 is RES0. */
> > - if (!cpu_isar_feature(aa64_fp16, env_archcpu(env))) {
> > + if (!cpu_isar_feature(any_fp16, env_archcpu(env))) {
>
> So we had a potential bug on aa32?
No, because right now we don't support AA32 FP16 yet (so
the aa32_fp16_arith check is temporarily testing an AA64
ID reg, as noted in a TODO comment in that function), and
anyway all our CPUs which have ARMv8 features also mandatorily
have AArch64 currently. This is mainly tidyup so we are in
a position to add a new v8-32-bit-only CPU if we want to.
thanks
--- PMM
