Re: [PATCH 0/1] Introduce Xlnx ZynqMP CAN controller for QEMU

[Jason Wang]

On 2020/2/5 上午11:23, Vikram Garhwal wrote:
Hi Jason,
Yes, I will maintain this NIC. Thanks for the help.

Regards,
Vikram


Good to know that.

Please update MAINTINERS and it would be better if you can draft a qtest 
for this NIC.

I leave some quick comments for the patch and I hope the patch could be 
reviewed by others as well.

Thanks



-----Original Message-----
From: Jason Wang <jasow...@redhat.com>
Sent: Tuesday, February 4, 2020 7:17 PM
To: Vikram Garhwal <f...@xilinx.com>; qemu-devel@nongnu.org
Subject: Re: [PATCH 0/1] Introduce Xlnx ZynqMP CAN controller for QEMU


On 2020/2/4 上午5:06, Vikram Garhwal wrote:
Example for single CAN:
      -object can-bus,id=canbus0 \
      -global driver=xlnx.zynqmp-can,property=canbus0,value=canbus0 \
      -object can-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0

Example for connecting both CAN:
      -object can-bus,id=canbus0 -object can-bus,id=canbus1 \
      -global driver=xlnx.zynqmp-can,property=canbus0,value=canbus0 \
      -global driver=xlnx.zynqmp-can,property=canbus1,value=canbus1 \
      -object can-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 \
      -object can-host-socketcan,id=socketcan1,if=vcan0,canbus=canbus1

Vikram Garhwal (1):
    hw/net/can: Introduce Xlnx ZynqMP CAN controller for QEMU

   hw/net/can/Makefile.objs         |    1 +
   hw/net/can/xlnx-zynqmp-can.c     | 1106
++++++++++++++++++++++++++++++++++++++
   include/hw/net/xlnx-zynqmp-can.h |   77 +++
   3 files changed, 1184 insertions(+)
   create mode 100644 hw/net/can/xlnx-zynqmp-can.c
   create mode 100644 include/hw/net/xlnx-zynqmp-can.h

Hi Vikram:

I would like to confirm that whether or not you would maintain this NIC.
(I think the answer is yes). I tend not to merge a NIC model without a
maintainer.

Thanks