Patchew URL: https://patchew.org/QEMU/1580483390-131164-1-git-send-email-imamm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v4 00/80] refactor main RAM allocation to use hostmem backend Message-id: 1580483390-131164-1-git-send-email-imamm...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/1580483390-131164-1-git-send-email-imamm...@redhat.com -> patchew/1580483390-131164-1-git-send-email-imamm...@redhat.com Switched to a new branch 'test' f7b9c62 tests:numa-test: use explicit memdev to specify node RAM eb0f943 tests/numa-test: make top level args dynamic and g_autofree(cli) cleanups 05a7ebf hostmem: fix strict bind policy eb4188b hostmem: introduce "prealloc-threads" property 13b58e1 make mem_path local variable 90ccc91 exec: drop bogus mem_path from qemu_ram_alloc_from_fd() f5ec506 exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize() 2da1a36 remove no longer used memory_region_allocate_system_memory() 431e57c sparc/niagara: use memdev for RAM ef754a6 sparc/sun4m: use memdev for RAM 05dfc25 sparc/leon3: use memdev for RAM 5b5a391 ppc/virtex_ml507: use memdev for RAM 5620528 ppc/virtex_ml507: remove unused arguments 12a3f8d ppc/spapr: use memdev for RAM 0a4a385 ppc/prep: use memdev for RAM c68dc4f ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM c0f1fdd ppc/{ppc440_bamboo, sam460ex}: drop RAM size fixup 7dea3c1 ppc/ppc405_boards: use memdev for RAM ebce804 ppc/ppc405_boards: add RAM size checks 90d7211 ppc/pnv: use memdev for RAM ec639f6 ppc/mac_oldworld: use memdev for RAM 23181a7 ppc/mac_newworld: use memdev for RAM 2ed160d ppc/e500: use memdev for RAM 6d1ca96 ppc/e500: drop RAM size fixup 0b021ee mips/mips_r4k: use memdev for RAM b02c471 mips/mips_mipssim: use memdev for RAM 7039ed0 mips/mips_malta: use memdev for RAM 40704d1 mips/mips_jazz: use memdev for RAM 802f031 mips/mips_fulong2e: use memdev for RAM 8a54d11 mips/mips_fulong2e: drop RAM size fixup 5e8f388 mips/boston: use memdev for RAM 17bbfaf m68k/next-cube: use memdev for RAM 3e40941 m68k/mcf5208: use memdev for RAM c6929f1 m68k/q800: use memdev for RAM f932543 m68k/an5206: use memdev for RAM b835844 lm32/milkymist: use memdev for RAM df9a5ef lm32/lm32_boards: use memdev for RAM 666b0c6 x86/pc: use memdev for RAM 5629d3f x86/microvm: use memdev for RAM 684a3fc hppa: use memdev for RAM 5514568 cris/axis_dev88: use memdev for RAM af9becd null-machine: use memdev for RAM ff11aed s390x/s390-virtio-ccw: use memdev for RAM 3775971 arm/xlnx-zcu102: use memdev for RAM 3030b07 arm/xlnx-versal-virt: use memdev for RAM 450060b arm/xilinx_zynq: use memdev for RAM 232374d arm/xilinx_zynq: drop RAM size fixup 4203dcb arm/virt: use memdev for RAM 1060cf7 arm/vexpress: use memdev for RAM 90e888e arm/versatilepb: use memdev for RAM f6c11d2 arm/sbsa-ref: use memdev for RAM 700e8df arm/sabrelite: use memdev for RAM 9707606 arm/raspi: use memdev for RAM d917b57 arm/palm: use memdev for RAM e21e58b arm/omap_sx1: use memdev for RAM 523ceed arm/nseries: use memdev for RAM b57cc47 arm/musicpal: use memdev for RAM 5b5745f arm/mps2: use memdev for RAM b009717 arm/mps2-tz: use memdev for RAM 128a0be arm/mcimx7d-sabre: use memdev for RAM 61579e5 arm/mcimx6ul-evk: use memdev for RAM e81ec2a arm/kzm: use memdev for RAM cc5f6c6 arm/kzm: drop RAM size fixup 3e4c48e arm/integratorcp: use memdev for RAM af95833 arm/imx25_pdk: use memdev for RAM c9edc2d arm/imx25_pdk: drop RAM size fixup bdf29fa arm/highbank: use memdev for RAM 102922b arm/digic_boards: use memdev for RAM 419a2ce arm/cubieboard: use memdev for RAM 9577b4a arm/collie: use memdev for RAM 0a924cf arm/aspeed: use memdev for RAM 791b49e arm/aspeed: actually check RAM size 8de04fd alpha/dp264: use memdev for RAM de3c2ca vl.c: ensure that ram_size matches size of machine.memory-backend 32f8326 vl.c: move -m parsing after memory backends has been processed 690a305 initialize MachineState::ram in NUMA case 7003896 machine: introduce convenience MachineState::ram bcce25a machine: alias -mem-path and -mem-prealloc into memory-foo backend 5762ea4 machine: introduce memory-backend property 6046198 numa: remove deprecated -mem-path fallback to anonymous RAM === OUTPUT BEGIN === 1/80 Checking commit 60461983c933 (numa: remove deprecated -mem-path fallback to anonymous RAM) 2/80 Checking commit 5762ea41ea77 (machine: introduce memory-backend property) 3/80 Checking commit bcce25a8e595 (machine: alias -mem-path and -mem-prealloc into memory-foo backend) 4/80 Checking commit 700389660de4 (machine: introduce convenience MachineState::ram) 5/80 Checking commit 690a30507aa5 (initialize MachineState::ram in NUMA case) 6/80 Checking commit 32f83261cd0d (vl.c: move -m parsing after memory backends has been processed) 7/80 Checking commit de3c2ca6c609 (vl.c: ensure that ram_size matches size of machine.memory-backend) 8/80 Checking commit 8de04fd7210c (alpha/dp264: use memdev for RAM) ERROR: spaces required around that '*' (ctx:WxV) #30: FILE: hw/alpha/alpha_sys.h:14: +PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4], ^ total: 1 errors, 0 warnings, 49 lines checked Patch 8/80 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/80 Checking commit 791b49e2380b (arm/aspeed: actually check RAM size) 10/80 Checking commit 0a924cf39439 (arm/aspeed: use memdev for RAM) 11/80 Checking commit 9577b4a9a698 (arm/collie: use memdev for RAM) 12/80 Checking commit 419a2cef223e (arm/cubieboard: use memdev for RAM) 13/80 Checking commit 102922bd0e7f (arm/digic_boards: use memdev for RAM) 14/80 Checking commit bdf29fa78691 (arm/highbank: use memdev for RAM) 15/80 Checking commit c9edc2dda2a6 (arm/imx25_pdk: drop RAM size fixup) 16/80 Checking commit af95833cb506 (arm/imx25_pdk: use memdev for RAM) 17/80 Checking commit 3e4c48ecbcf1 (arm/integratorcp: use memdev for RAM) 18/80 Checking commit cc5f6c68f998 (arm/kzm: drop RAM size fixup) 19/80 Checking commit e81ec2a37264 (arm/kzm: use memdev for RAM) 20/80 Checking commit 61579e5f0415 (arm/mcimx6ul-evk: use memdev for RAM) 21/80 Checking commit 128a0bea6ed4 (arm/mcimx7d-sabre: use memdev for RAM) 22/80 Checking commit b0097170c7a2 (arm/mps2-tz: use memdev for RAM) 23/80 Checking commit 5b5745f35ba7 (arm/mps2: use memdev for RAM) 24/80 Checking commit b57cc476faf9 (arm/musicpal: use memdev for RAM) 25/80 Checking commit 523ceeddddbf (arm/nseries: use memdev for RAM) 26/80 Checking commit e21e58b89410 (arm/omap_sx1: use memdev for RAM) 27/80 Checking commit d917b572c863 (arm/palm: use memdev for RAM) 28/80 Checking commit 97076061bce7 (arm/raspi: use memdev for RAM) 29/80 Checking commit 700e8df7cc99 (arm/sabrelite: use memdev for RAM) 30/80 Checking commit f6c11d27d6ff (arm/sbsa-ref: use memdev for RAM) 31/80 Checking commit 90e888ed5ef5 (arm/versatilepb: use memdev for RAM) 32/80 Checking commit 1060cf75c120 (arm/vexpress: use memdev for RAM) 33/80 Checking commit 4203dcb26673 (arm/virt: use memdev for RAM) 34/80 Checking commit 232374d4e135 (arm/xilinx_zynq: drop RAM size fixup) 35/80 Checking commit 450060bf0283 (arm/xilinx_zynq: use memdev for RAM) 36/80 Checking commit 3030b07401ba (arm/xlnx-versal-virt: use memdev for RAM) 37/80 Checking commit 37759714f341 (arm/xlnx-zcu102: use memdev for RAM) 38/80 Checking commit ff11aed3ea7d (s390x/s390-virtio-ccw: use memdev for RAM) 39/80 Checking commit af9becd12221 (null-machine: use memdev for RAM) 40/80 Checking commit 551456883977 (cris/axis_dev88: use memdev for RAM) 41/80 Checking commit 684a3fc152b6 (hppa: use memdev for RAM) 42/80 Checking commit 5629d3ff514d (x86/microvm: use memdev for RAM) 43/80 Checking commit 666b0c6278fb (x86/pc: use memdev for RAM) 44/80 Checking commit df9a5ef15410 (lm32/lm32_boards: use memdev for RAM) 45/80 Checking commit b83584403008 (lm32/milkymist: use memdev for RAM) 46/80 Checking commit f932543a1506 (m68k/an5206: use memdev for RAM) 47/80 Checking commit c6929f129e8c (m68k/q800: use memdev for RAM) 48/80 Checking commit 3e409410c561 (m68k/mcf5208: use memdev for RAM) 49/80 Checking commit 17bbfaf7bbd6 (m68k/next-cube: use memdev for RAM) 50/80 Checking commit 5e8f38897e54 (mips/boston: use memdev for RAM) 51/80 Checking commit 8a54d11de45c (mips/mips_fulong2e: drop RAM size fixup) 52/80 Checking commit 802f0316233d (mips/mips_fulong2e: use memdev for RAM) 53/80 Checking commit 40704d14a039 (mips/mips_jazz: use memdev for RAM) 54/80 Checking commit 7039ed00bd7f (mips/mips_malta: use memdev for RAM) 55/80 Checking commit b02c4714c12e (mips/mips_mipssim: use memdev for RAM) 56/80 Checking commit 0b021eede5f7 (mips/mips_r4k: use memdev for RAM) 57/80 Checking commit 6d1ca96fe5d7 (ppc/e500: drop RAM size fixup) 58/80 Checking commit 2ed160d8c4e8 (ppc/e500: use memdev for RAM) 59/80 Checking commit 23181a7de463 (ppc/mac_newworld: use memdev for RAM) 60/80 Checking commit ec639f6bb3b1 (ppc/mac_oldworld: use memdev for RAM) 61/80 Checking commit 90d7211b8eb7 (ppc/pnv: use memdev for RAM) 62/80 Checking commit ebce8044169b (ppc/ppc405_boards: add RAM size checks) 63/80 Checking commit 7dea3c19dda9 (ppc/ppc405_boards: use memdev for RAM) 64/80 Checking commit c0f1fddf078c (ppc/{ppc440_bamboo, sam460ex}: drop RAM size fixup) 65/80 Checking commit c68dc4f3f534 (ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM) WARNING: Block comments use a leading /* on a separate line #50: FILE: hw/ppc/ppc4xx_devs.c:669: +/* Split RAM between SDRAM banks. total: 0 errors, 1 warnings, 103 lines checked Patch 65/80 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 66/80 Checking commit 0a4a38520fce (ppc/prep: use memdev for RAM) 67/80 Checking commit 12a3f8dd0e18 (ppc/spapr: use memdev for RAM) 68/80 Checking commit 5620528e5ce7 (ppc/virtex_ml507: remove unused arguments) 69/80 Checking commit 5b5a39153e64 (ppc/virtex_ml507: use memdev for RAM) 70/80 Checking commit 05dfc25f60ae (sparc/leon3: use memdev for RAM) 71/80 Checking commit ef754a657dc0 (sparc/sun4m: use memdev for RAM) 72/80 Checking commit 431e57c1d62d (sparc/niagara: use memdev for RAM) 73/80 Checking commit 2da1a362ea8e (remove no longer used memory_region_allocate_system_memory()) 74/80 Checking commit f5ec506ef34d (exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()) 75/80 Checking commit 90ccc91a4efe (exec: drop bogus mem_path from qemu_ram_alloc_from_fd()) 76/80 Checking commit 13b58e138d12 (make mem_path local variable) 77/80 Checking commit eb4188bec297 (hostmem: introduce "prealloc-threads" property) 78/80 Checking commit 05a7ebfce7d1 (hostmem: fix strict bind policy) 79/80 Checking commit eb0f943735b8 (tests/numa-test: make top level args dynamic and g_autofree(cli) cleanups) 80/80 Checking commit f7b9c62f1274 (tests:numa-test: use explicit memdev to specify node RAM) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1580483390-131164-1-git-send-email-imamm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com