Patchew URL: https://patchew.org/QEMU/1580483390-131164-1-git-send-email-imamm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v4 00/80] refactor main RAM allocation to use hostmem backend Message-id: 1580483390-131164-1-git-send-email-imamm...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1580483390-131164-1-git-send-email-imamm...@redhat.com -> patchew/1580483390-131164-1-git-send-email-imamm...@redhat.com - [tag update] patchew/20200129235614.29829-1-richard.hender...@linaro.org -> patchew/20200129235614.29829-1-richard.hender...@linaro.org - [tag update] patchew/20200130113223.31046-1-alex.ben...@linaro.org -> patchew/20200130113223.31046-1-alex.ben...@linaro.org - [tag update] patchew/20200131010941.10636-1-phi...@redhat.com -> patchew/20200131010941.10636-1-phi...@redhat.com Switched to a new branch 'test' 8ed2b43 tests:numa-test: use explicit memdev to specify node RAM 96981a3 tests/numa-test: make top level args dynamic and g_autofree(cli) cleanups 1b17c3c hostmem: fix strict bind policy d955599 hostmem: introduce "prealloc-threads" property 7299900 make mem_path local variable 7d9472d exec: drop bogus mem_path from qemu_ram_alloc_from_fd() 0ed2ef7 exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize() ed0b9e0 remove no longer used memory_region_allocate_system_memory() 974e8f1 sparc/niagara: use memdev for RAM 8e29394 sparc/sun4m: use memdev for RAM c637f30 sparc/leon3: use memdev for RAM 4b67ae6 ppc/virtex_ml507: use memdev for RAM 977a3e6 ppc/virtex_ml507: remove unused arguments 68f42ff ppc/spapr: use memdev for RAM fe9c8c0 ppc/prep: use memdev for RAM caf05a9 ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM 92bcec5 ppc/{ppc440_bamboo, sam460ex}: drop RAM size fixup ab40bd5 ppc/ppc405_boards: use memdev for RAM d070d6a ppc/ppc405_boards: add RAM size checks c99cfee ppc/pnv: use memdev for RAM 508faf0 ppc/mac_oldworld: use memdev for RAM 7fb3329 ppc/mac_newworld: use memdev for RAM 7c01ad4 ppc/e500: use memdev for RAM 087b3cc ppc/e500: drop RAM size fixup 4c4e0dd mips/mips_r4k: use memdev for RAM 847c6dd mips/mips_mipssim: use memdev for RAM 687dd37 mips/mips_malta: use memdev for RAM 02a18d5 mips/mips_jazz: use memdev for RAM 4684691 mips/mips_fulong2e: use memdev for RAM a880e6e mips/mips_fulong2e: drop RAM size fixup 770fcdc mips/boston: use memdev for RAM f85d55d m68k/next-cube: use memdev for RAM efdbfd3 m68k/mcf5208: use memdev for RAM 577296f m68k/q800: use memdev for RAM 2b90f02 m68k/an5206: use memdev for RAM 7d4530e lm32/milkymist: use memdev for RAM 2854ae4 lm32/lm32_boards: use memdev for RAM bfbc405 x86/pc: use memdev for RAM 465b9fd x86/microvm: use memdev for RAM 1f28740 hppa: use memdev for RAM c18e0f4 cris/axis_dev88: use memdev for RAM 840d8f4 null-machine: use memdev for RAM c72e05d s390x/s390-virtio-ccw: use memdev for RAM 3e20a8d arm/xlnx-zcu102: use memdev for RAM 4b27f9b arm/xlnx-versal-virt: use memdev for RAM bdebad0 arm/xilinx_zynq: use memdev for RAM a2127ad arm/xilinx_zynq: drop RAM size fixup 49bb455 arm/virt: use memdev for RAM 1ac6f86 arm/vexpress: use memdev for RAM 4faba44 arm/versatilepb: use memdev for RAM b63ed7e arm/sbsa-ref: use memdev for RAM cee86a5 arm/sabrelite: use memdev for RAM 4c75a75 arm/raspi: use memdev for RAM 810bc8d arm/palm: use memdev for RAM 78e60a6 arm/omap_sx1: use memdev for RAM 82a0793 arm/nseries: use memdev for RAM d754027 arm/musicpal: use memdev for RAM b595ccc arm/mps2: use memdev for RAM a7c644a arm/mps2-tz: use memdev for RAM bc98d2a arm/mcimx7d-sabre: use memdev for RAM 698978b arm/mcimx6ul-evk: use memdev for RAM 4c7fe45 arm/kzm: use memdev for RAM fb49cbf arm/kzm: drop RAM size fixup 046b683 arm/integratorcp: use memdev for RAM 3fb1840 arm/imx25_pdk: use memdev for RAM b4e93f7 arm/imx25_pdk: drop RAM size fixup 29ac690 arm/highbank: use memdev for RAM cf681b6 arm/digic_boards: use memdev for RAM a8b8a8a arm/cubieboard: use memdev for RAM d279b9c arm/collie: use memdev for RAM 6544ba6 arm/aspeed: use memdev for RAM bdf9295 arm/aspeed: actually check RAM size 589b205 alpha/dp264: use memdev for RAM 39f1710 vl.c: ensure that ram_size matches size of machine.memory-backend 3bfe66d vl.c: move -m parsing after memory backends has been processed d66265f initialize MachineState::ram in NUMA case e58426e machine: introduce convenience MachineState::ram 7a57426 machine: alias -mem-path and -mem-prealloc into memory-foo backend 962476a machine: introduce memory-backend property afeeadd numa: remove deprecated -mem-path fallback to anonymous RAM === OUTPUT BEGIN === 1/80 Checking commit afeeadd29d2b (numa: remove deprecated -mem-path fallback to anonymous RAM) 2/80 Checking commit 962476ab28ea (machine: introduce memory-backend property) 3/80 Checking commit 7a57426f6563 (machine: alias -mem-path and -mem-prealloc into memory-foo backend) 4/80 Checking commit e58426eaff73 (machine: introduce convenience MachineState::ram) 5/80 Checking commit d66265f1ca6b (initialize MachineState::ram in NUMA case) 6/80 Checking commit 3bfe66d0b20b (vl.c: move -m parsing after memory backends has been processed) 7/80 Checking commit 39f17105520f (vl.c: ensure that ram_size matches size of machine.memory-backend) 8/80 Checking commit 589b20511ceb (alpha/dp264: use memdev for RAM) ERROR: spaces required around that '*' (ctx:WxV) #30: FILE: hw/alpha/alpha_sys.h:14: +PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4], ^ total: 1 errors, 0 warnings, 49 lines checked Patch 8/80 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/80 Checking commit bdf9295e30f7 (arm/aspeed: actually check RAM size) 10/80 Checking commit 6544ba6d9293 (arm/aspeed: use memdev for RAM) 11/80 Checking commit d279b9caf47a (arm/collie: use memdev for RAM) 12/80 Checking commit a8b8a8ae80f2 (arm/cubieboard: use memdev for RAM) 13/80 Checking commit cf681b6babf9 (arm/digic_boards: use memdev for RAM) 14/80 Checking commit 29ac690f07e1 (arm/highbank: use memdev for RAM) 15/80 Checking commit b4e93f76a9d9 (arm/imx25_pdk: drop RAM size fixup) 16/80 Checking commit 3fb1840036bc (arm/imx25_pdk: use memdev for RAM) 17/80 Checking commit 046b683b92a7 (arm/integratorcp: use memdev for RAM) 18/80 Checking commit fb49cbf013f6 (arm/kzm: drop RAM size fixup) 19/80 Checking commit 4c7fe45a3689 (arm/kzm: use memdev for RAM) 20/80 Checking commit 698978b00571 (arm/mcimx6ul-evk: use memdev for RAM) 21/80 Checking commit bc98d2ad493f (arm/mcimx7d-sabre: use memdev for RAM) 22/80 Checking commit a7c644a879eb (arm/mps2-tz: use memdev for RAM) 23/80 Checking commit b595ccce50aa (arm/mps2: use memdev for RAM) 24/80 Checking commit d7540271b0f0 (arm/musicpal: use memdev for RAM) 25/80 Checking commit 82a079398d9d (arm/nseries: use memdev for RAM) 26/80 Checking commit 78e60a6d2935 (arm/omap_sx1: use memdev for RAM) 27/80 Checking commit 810bc8d9cd36 (arm/palm: use memdev for RAM) 28/80 Checking commit 4c75a7519139 (arm/raspi: use memdev for RAM) 29/80 Checking commit cee86a5c37f4 (arm/sabrelite: use memdev for RAM) 30/80 Checking commit b63ed7e15207 (arm/sbsa-ref: use memdev for RAM) 31/80 Checking commit 4faba449fd7e (arm/versatilepb: use memdev for RAM) 32/80 Checking commit 1ac6f868e83e (arm/vexpress: use memdev for RAM) 33/80 Checking commit 49bb455abd5a (arm/virt: use memdev for RAM) 34/80 Checking commit a2127ad1ae04 (arm/xilinx_zynq: drop RAM size fixup) 35/80 Checking commit bdebad025644 (arm/xilinx_zynq: use memdev for RAM) 36/80 Checking commit 4b27f9bc5c87 (arm/xlnx-versal-virt: use memdev for RAM) 37/80 Checking commit 3e20a8d36bcb (arm/xlnx-zcu102: use memdev for RAM) 38/80 Checking commit c72e05d72c4d (s390x/s390-virtio-ccw: use memdev for RAM) 39/80 Checking commit 840d8f458e02 (null-machine: use memdev for RAM) 40/80 Checking commit c18e0f473a7e (cris/axis_dev88: use memdev for RAM) 41/80 Checking commit 1f28740de254 (hppa: use memdev for RAM) 42/80 Checking commit 465b9fdb5ab7 (x86/microvm: use memdev for RAM) 43/80 Checking commit bfbc4055203f (x86/pc: use memdev for RAM) 44/80 Checking commit 2854ae456a0d (lm32/lm32_boards: use memdev for RAM) 45/80 Checking commit 7d4530e5c2f5 (lm32/milkymist: use memdev for RAM) 46/80 Checking commit 2b90f02339ea (m68k/an5206: use memdev for RAM) 47/80 Checking commit 577296f1b6da (m68k/q800: use memdev for RAM) 48/80 Checking commit efdbfd389a9f (m68k/mcf5208: use memdev for RAM) 49/80 Checking commit f85d55df454a (m68k/next-cube: use memdev for RAM) 50/80 Checking commit 770fcdc55b1c (mips/boston: use memdev for RAM) 51/80 Checking commit a880e6ef6d04 (mips/mips_fulong2e: drop RAM size fixup) 52/80 Checking commit 4684691eccf7 (mips/mips_fulong2e: use memdev for RAM) 53/80 Checking commit 02a18d573411 (mips/mips_jazz: use memdev for RAM) 54/80 Checking commit 687dd378518d (mips/mips_malta: use memdev for RAM) 55/80 Checking commit 847c6dd169bf (mips/mips_mipssim: use memdev for RAM) 56/80 Checking commit 4c4e0dd52637 (mips/mips_r4k: use memdev for RAM) 57/80 Checking commit 087b3cc0289f (ppc/e500: drop RAM size fixup) 58/80 Checking commit 7c01ad407638 (ppc/e500: use memdev for RAM) 59/80 Checking commit 7fb33292c0a0 (ppc/mac_newworld: use memdev for RAM) 60/80 Checking commit 508faf061385 (ppc/mac_oldworld: use memdev for RAM) 61/80 Checking commit c99cfeef48ea (ppc/pnv: use memdev for RAM) 62/80 Checking commit d070d6aa369a (ppc/ppc405_boards: add RAM size checks) 63/80 Checking commit ab40bd5f6686 (ppc/ppc405_boards: use memdev for RAM) 64/80 Checking commit 92bcec52e24c (ppc/{ppc440_bamboo, sam460ex}: drop RAM size fixup) 65/80 Checking commit caf05a9270d7 (ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM) WARNING: Block comments use a leading /* on a separate line #50: FILE: hw/ppc/ppc4xx_devs.c:669: +/* Split RAM between SDRAM banks. total: 0 errors, 1 warnings, 103 lines checked Patch 65/80 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 66/80 Checking commit fe9c8c05a837 (ppc/prep: use memdev for RAM) 67/80 Checking commit 68f42ffd08ea (ppc/spapr: use memdev for RAM) 68/80 Checking commit 977a3e69037c (ppc/virtex_ml507: remove unused arguments) 69/80 Checking commit 4b67ae6c834f (ppc/virtex_ml507: use memdev for RAM) 70/80 Checking commit c637f3060022 (sparc/leon3: use memdev for RAM) 71/80 Checking commit 8e29394e56dc (sparc/sun4m: use memdev for RAM) 72/80 Checking commit 974e8f145a52 (sparc/niagara: use memdev for RAM) 73/80 Checking commit ed0b9e040ad1 (remove no longer used memory_region_allocate_system_memory()) 74/80 Checking commit 0ed2ef789253 (exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()) 75/80 Checking commit 7d9472d31549 (exec: drop bogus mem_path from qemu_ram_alloc_from_fd()) 76/80 Checking commit 72999001b216 (make mem_path local variable) 77/80 Checking commit d95559954854 (hostmem: introduce "prealloc-threads" property) 78/80 Checking commit 1b17c3c5e264 (hostmem: fix strict bind policy) 79/80 Checking commit 96981a33fbf8 (tests/numa-test: make top level args dynamic and g_autofree(cli) cleanups) 80/80 Checking commit 8ed2b43e326f (tests:numa-test: use explicit memdev to specify node RAM) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1580483390-131164-1-git-send-email-imamm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
