On Thu, Jun 9, 2011 at 12:13 AM, Andreas Färber <andreas.faer...@web.de> wrote: > Am 21.12.2010 um 21:01 schrieb Andreas Färber: > >> From: Hervé Poussineau <hpous...@reactos.org> >> >> v1: >> * Coding style fixes. >> >> Signed-off-by: Hervé Poussineau <hpous...@reactos.org> >> Cc: Alexander Graf <ag...@suse.de> >> Signed-off-by: Andreas Färber <andreas.faer...@web.de> >> --- >> >> Hello Alex, >> >> Seeing the discussions about Leon3, is this the way to go for ppc? Is >> ppc.[hc] right? >> >> The unconditional use of 6xx looks suspicious to me, no? >> Should we rename cpu_device_irq_request() to cpu_device_irq_request_6xx()? >> >> Regards, >> Andreas > > Ping? Any guidance on how to proceed with this?
The patch looks OK, though the qdev method is not used. Ideally after the patch, the devices and even the board level shouldn't use CPUState but DeviceState.
