On Mon, 6 Jan 2020 15:23:38 -0300
Daniel Henrique Barboza <danielhb...@gmail.com> wrote:
> 'err_out' can be removed and be replaced by 'return -errno'
> in its only instance in the function.
>
> CC: Greg Kurz <gr...@kaod.org>
> Signed-off-by: Daniel Henrique Barboza <danielhb...@gmail.com>
> ---
I don't really mind, but I confirm this doesn't change behavior.
Acked-by: Greg Kurz <gr...@kaod.org>
What's the plan to get this and the other 9p related patches merged ?
Through the trivial tree or each subsystem tree ?
> fsdev/virtfs-proxy-helper.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index 0d4de49dcf..aa1ab2590d 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -287,8 +287,7 @@ static int setugid(int uid, int gid, int *suid, int *sgid)
> *sgid = getegid();
>
> if (setresgid(-1, gid, *sgid) == -1) {
> - retval = -errno;
> - goto err_out;
> + return -errno;
> }
>
> if (setresuid(-1, uid, *suid) == -1) {
> @@ -322,7 +321,6 @@ err_sgid:
> if (setresgid(-1, *sgid, *sgid) == -1) {
> abort();
> }
> -err_out:
> return retval;
> }
>
