On Wed, Dec 18, 2019 at 8:29 PM Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > We don't need to explicit this obvious switch fall through. > Stay consistent with the rest of the codebase. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > ---
I see you covered two cases of such comment (in patches 5 and 6). But why didn't you than cover the following cases: block/vhdx.c: case PAYLOAD_BLOCK_NOT_PRESENT: /* fall through */ block/vhdx.c: case PAYLOAD_BLOCK_NOT_PRESENT: /* fall through */ hw/net/rtl8139.c: case 1: /* fall through */ hw/net/rtl8139.c: case 2: /* fall through */ contrib/vhost-user-scsi/vhost-user-scsi.c: case 1: /* fall through */ (this one needs full switch block reformatting, but can this be changed, since it is in "contrib"?) ? Thanks, Aleksandar > Cc: Peter Chubb <peter.ch...@nicta.com.au> > Cc: Markus Armbruster <arm...@redhat.com> > Cc: Peter Maydell <peter.mayd...@linaro.org> > Cc: Andrey Smirnov <andrew.smir...@gmail.com> > Cc: qemu-...@nongnu.org > --- > hw/pci-host/designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c > index 71e9b0d9b5..dd245516dd 100644 > --- a/hw/pci-host/designware.c > +++ b/hw/pci-host/designware.c > @@ -182,7 +182,7 @@ designware_pcie_root_config_read(PCIDevice *d, uint32_t > address, int len) > break; > > case DESIGNWARE_PCIE_ATU_CR1: > - case DESIGNWARE_PCIE_ATU_CR2: /* FALLTHROUGH */ > + case DESIGNWARE_PCIE_ATU_CR2: > val = viewport->cr[(address - DESIGNWARE_PCIE_ATU_CR1) / > sizeof(uint32_t)]; > break; > -- > 2.21.0 > >
