On 18/12/2019 20.25, Philippe Mathieu-Daudé wrote:
> We don't need to explicit these obvious switch fall through
> comments. Stay consistent with the rest of the codebase.
>
> Suggested-by: Thomas Huth <th...@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
...
> diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
> index c01ce4f078..5a83678f64 100644
> --- a/hw/net/imx_fec.c
> +++ b/hw/net/imx_fec.c
> @@ -901,8 +901,8 @@ static void imx_eth_write(void *opaque, hwaddr offset,
> uint64_t value,
> s->regs[index] = 0;
> }
> break;
> - case ENET_TDAR1: /* FALLTHROUGH */
> - case ENET_TDAR2: /* FALLTHROUGH */
> + case ENET_TDAR1:
> + case ENET_TDAR2:
> if (unlikely(single_tx_ring)) {
> qemu_log_mask(LOG_GUEST_ERROR,
> "[%s]%s: trying to access TDAR2 or TDAR1\n",
Reviewed-by: Thomas Huth <th...@redhat.com>
