On 12/13/19 10:00 PM, Niek Linnenbank wrote:
On Fri, Dec 13, 2019 at 12:56 AM Philippe Mathieu-Daudé
<phi...@redhat.com <mailto:phi...@redhat.com>> wrote:
Hi Niek,
On 12/11/19 11:34 PM, Niek Linnenbank wrote:
> Ping!
>
> Anyone would like to comment on this driver?
>
> I finished the rework on all previous comments in this series.
>
> Currently debugging the hflags error reported by Philippe.
> After that, I'm ready to send out v2 of these patches.
>
> Regards,
> Niek
>
> On Mon, Dec 2, 2019 at 10:10 PM Niek Linnenbank
> <nieklinnenb...@gmail.com <mailto:nieklinnenb...@gmail.com>
<mailto:nieklinnenb...@gmail.com <mailto:nieklinnenb...@gmail.com>>>
wrote:
>
> The Allwinner H3 System on Chip contains an integrated storage
> controller for Secure Digital (SD) and Multi Media Card (MMC)
> interfaces. This commit adds support for the Allwinner H3
> SD/MMC storage controller with the following emulated features:
>
> * DMA transfers
> * Direct FIFO I/O
> * Short/Long format command responses
> * Auto-Stop command (CMD12)
> * Insert & remove card detection
>
> Signed-off-by: Niek Linnenbank <nieklinnenb...@gmail.com
<mailto:nieklinnenb...@gmail.com>
> <mailto:nieklinnenb...@gmail.com
<mailto:nieklinnenb...@gmail.com>>>
> ---
> hw/arm/allwinner-h3.c | 20 +
> hw/arm/orangepi.c | 17 +
> hw/sd/Makefile.objs | 1 +
> hw/sd/allwinner-h3-sdhost.c | 791
++++++++++++++++++++++++++++
> hw/sd/trace-events | 7 +
> include/hw/arm/allwinner-h3.h | 2 +
> include/hw/sd/allwinner-h3-sdhost.h | 73 +++
> 7 files changed, 911 insertions(+)
> create mode 100644 hw/sd/allwinner-h3-sdhost.c
> create mode 100644 include/hw/sd/allwinner-h3-sdhost.h
[...]
Thanks again for all of your helpful comments Philippe!
I've started to rework the patch.
One question about adding tags in the commit message: should I
already add 'Reviewed-by: ' when I re-send v2 of this patch? Or should
that be added after you have seen the v2 changes?
You shouldn't add the Reviewed-by tag until explicitly given by the
reviewer. If the changes are trivial, it is easy to conditionally give
the tag such "If ... is done: R-b", "With ... fixed: R-b".
Since this is your first contribution, I have been more careful. Also
since your patch is already of very good quality, I'v been a bit picky
regarding few details.
Since there are too many comments, so I prefer to fully review the v2 of
this patch again.
Regards,
Phil.
