On Wed, May 18, 2011 at 12:00:46PM +0200, Alex Zuepke wrote: > Hi, > > Peter Maydell schrieb: > > On 25 March 2011 10:54, Alex Zuepke <azue...@sysgo.com> wrote: > >> while digging through some problems with BKPT exceptions on ARM, I > >> discovered that QEMU does not update IFSR on prefetch aborts. This > >> should be done since ARMv6 according to ARM docs. Please include. > > > > This patch is the wrong approach to fixing this bug -- the > > updating of the IFSR needs to be done when the exception > > is taken, not when we translate the breakpoint instruction. > > > > I'll put this on my todo list. If you happen to have a convenient > > test case demonstrating the problem, that would make a fix happen > > faster ;-) > > > > -- PMM > > I tried to fix it, new patch attached. > But I'm not sure if it is required for semihosting as well. > > On ARMv7-M bkpt works differently, and debug registers aren't > implemented yet, so I didn't touch it. >
Thanks, applied. In the future, could you please send the patch inline, or at least attach a patch that can be applied with git am? -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurel...@aurel32.net http://www.aurel32.net
