Hi Philippe,
On Tue, Dec 10, 2019 at 10:02 AM Philippe Mathieu-Daudé <phi...@redhat.com>
wrote:
> On 12/2/19 10:09 PM, Niek Linnenbank wrote:
> > The Allwinner H3 is a System on Chip containing four ARM Cortex A7
> > processor cores. Features and specifications include DDR2/DDR3 memory,
> > SD/MMC storage cards, 10/100/1000Mbit ethernet, USB 2.0, HDMI and
> > various I/O modules. This commit adds support for the Allwinner H3
> > System on Chip.
> >
> > Signed-off-by: Niek Linnenbank <nieklinnenb...@gmail.com>
> > ---
> [...]
> > +
> > + /* UART */
> > + if (serial_hd(0)) {
>
> As the uart0 is always mapped in the SoC, don't use 'if serial_hd()',
> instead map it regardless a console is connected.
>
Indeed, the UARTs should always be mapped for this SoC.
Noted, I'll solve this too for in the v2 patch update.
Regards,
Niek
>
> > + serial_mm_init(get_system_memory(), AW_H3_UART0_REG_BASE, 2,
> > + s->irq[AW_H3_GIC_SPI_UART0], 115200,
> serial_hd(0),
> > + DEVICE_NATIVE_ENDIAN);
> > + }
> > +
> > + /* Unimplemented devices */
> > + create_unimplemented_device("display-engine", AW_H3_DE_BASE,
> AW_H3_DE_SIZE);
> > + create_unimplemented_device("dma", AW_H3_DMA_BASE, AW_H3_DMA_SIZE);
> > + create_unimplemented_device("lcd0", AW_H3_LCD0_BASE,
> AW_H3_LCD0_SIZE);
> > + create_unimplemented_device("lcd1", AW_H3_LCD1_BASE,
> AW_H3_LCD1_SIZE);
> > + create_unimplemented_device("gpu", AW_H3_GPU_BASE, AW_H3_GPU_SIZE);
> > + create_unimplemented_device("hdmi", AW_H3_HDMI_BASE,
> AW_H3_HDMI_SIZE);
> > + create_unimplemented_device("rtc", AW_H3_RTC_BASE, AW_H3_RTC_SIZE);
> > + create_unimplemented_device("audio-codec", AW_H3_AC_BASE,
> AW_H3_AC_SIZE);
>
>
--
Niek Linnenbank
