On Thu, 28 Nov 2019 17:10:38 +0100 Janosch Frank <fran...@linux.ibm.com> wrote:
> On 11/28/19 4:28 PM, Thomas Huth wrote: > > Would it make sense to hide all these changes in decode_basedisp_s() > > instead? ... so that decode_basedisp_s() returns 0 if env->pv == true ? > > ... or are there still cases where we need real values from > > decode_basedisp_s() in case of env->pv==true? > > I'd like to keep decode_basedisp_s() as is, but how about a static > function in ioinst.c called something like get_address_from_regs()? > > It'll call decode_basedisp_s() or return 0. We could do something like that; but do we ever get there for other instruction formats as well? It feels a bit odd to single out this one.
pgpvEE_tD8j2V.pgp
Description: OpenPGP digital signature
