On Fri, 22 Nov 2019 01:17:12 -0800 (PST) no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20191122074826.1373-1-tao3...@intel.com/ > do not ignore warnings "line over 80 characters", just fix them
> > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [PATCH v17 00/14] Build ACPI Heterogeneous Memory Attribute Table > (HMAT) > Type: series > Message-id: 20191122074826.1373-1-tao3...@intel.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > - [tag update] > patchew/20191121000843.24844-1-beata.michal...@linaro.org -> > patchew/20191121000843.24844-1-beata.michal...@linaro.org > - [tag update] patchew/20191122080039.12771-1-arm...@redhat.com -> > patchew/20191122080039.12771-1-arm...@redhat.com > Switched to a new branch 'test' > 9192aa6 tests/bios-tables-test: add test cases for ACPI HMAT > 309fd85 tests/numa: Add case for QMP build HMAT > 864da49 hmat acpi: Build Memory Side Cache Information Structure(s) > 6d92931 hmat acpi: Build System Locality Latency and Bandwidth Information > Structure(s) > 39ba308 hmat acpi: Build Memory Proximity Domain Attributes Structure(s) > 7d0bffc numa: Extend CLI to provide memory side cache information > 3fc8a54 numa: Extend CLI to provide memory latency and bandwidth information > 592a96a numa: Extend CLI to provide initiator information for numa nodes > 7032fc4 tests: Add test for QAPI builtin type time > 2d89c93 qapi: Add builtin type time > dbe82f5 util/cutils: Add qemu_strtotime_ns() > 2fef66f util/cutils: refactor do_strtosz() to support suffixes list > 2cae457 util/cutils: Use qemu_strtold_finite to parse size > a691b5f util/cutils: Add Add qemu_strtold and qemu_strtold_finite > > === OUTPUT BEGIN === > 1/14 Checking commit a691b5f92191 (util/cutils: Add Add qemu_strtold and > qemu_strtold_finite) > ERROR: consider using qemu_strtold in preference to strtold > #61: FILE: util/cutils.c:636: > + *result = strtold(nptr, &ep); > > total: 1 errors, 0 warnings, 69 lines checked > > Patch 1/14 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 2/14 Checking commit 2cae457669b9 (util/cutils: Use qemu_strtold_finite to > parse size) > 3/14 Checking commit 2fef66fd2a82 (util/cutils: refactor do_strtosz() to > support suffixes list) > 4/14 Checking commit dbe82f50cf86 (util/cutils: Add qemu_strtotime_ns()) > 5/14 Checking commit 2d89c9350115 (qapi: Add builtin type time) > 6/14 Checking commit 7032fc4756a0 (tests: Add test for QAPI builtin type time) > 7/14 Checking commit 592a96a0ff21 (numa: Extend CLI to provide initiator > information for numa nodes) > 8/14 Checking commit 3fc8a542a4b7 (numa: Extend CLI to provide memory latency > and bandwidth information) > WARNING: line over 80 characters > #130: FILE: hw/core/numa.c:299: > + /* Set lb_info_provided bit 0 as 1, latency information is > provided */ > > total: 0 errors, 1 warnings, 462 lines checked > > Patch 8/14 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 9/14 Checking commit 7d0bffca6382 (numa: Extend CLI to provide memory side > cache information) > 10/14 Checking commit 39ba308b5612 (hmat acpi: Build Memory Proximity Domain > Attributes Structure(s)) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #72: > new file mode 100644 > > total: 0 errors, 1 warnings, 185 lines checked > > Patch 10/14 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 11/14 Checking commit 6d92931a0a40 (hmat acpi: Build System Locality Latency > and Bandwidth Information Structure(s)) > 12/14 Checking commit 864da49c0ce4 (hmat acpi: Build Memory Side Cache > Information Structure(s)) > 13/14 Checking commit 309fd85d39fc (tests/numa: Add case for QMP build HMAT) > WARNING: line over 80 characters > #124: FILE: tests/numa-test.c:433: > + g_assert(!qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'x-exit-preconfig' > }"))); > > WARNING: line over 80 characters > #159: FILE: tests/numa-test.c:468: > + g_assert(!qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'x-exit-preconfig' > }"))); > > WARNING: line over 80 characters > #206: FILE: tests/numa-test.c:515: > + g_assert(!qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'x-exit-preconfig' > }"))); > > total: 0 errors, 3 warnings, 206 lines checked > > Patch 13/14 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 14/14 Checking commit 9192aa6b273f (tests/bios-tables-test: add test cases > for ACPI HMAT) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #106: > new file mode 100644 > > total: 0 errors, 1 warnings, 65 lines checked > > Patch 14/14 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20191122074826.1373-1-tao3...@intel.com/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-de...@redhat.com
