Re: [RFC PATCH 05/11] gdbstub: add helper for 128 bit registers

[Richard Henderson]

On 11/15/19 6:29 PM, Alex Bennée wrote:
> +static inline int gdb_get_reg128(uint8_t *mem_buf, uint64_t val_hi,
> +                                 uint64_t val_lo)
> +{
> +    stq_p(mem_buf, val_hi);
> +    stq_p(mem_buf + 8, val_lo);
> +    return 16;

Since stq_p itself depends on TARGET_WORDS_BIGENDIAN,
I think the word ordering here should as well.


r~