On Wed, 13 Nov 2019 15:43:44 +0100
Jiri Denemark <jdene...@redhat.com> wrote:
> Hi David.
>
> On Wed, Oct 30, 2019 at 17:32:43 +0100, David Gibson wrote:
> > We have to set the default model of all machine classes, not just for the
> > active one. Otherwise, "query-machines" will indicate the wrong CPU model
> > ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type".
> >
> > s390x already fixed this in de60a92e "s390x/kvm: Set default cpu model for
> > all machine classes". This patch applies a similar fix for the pseries-*
> > machine types on ppc64.
> >
> > Doing a
> > {"execute":"query-machines"}
> > under KVM now results in
> > {
> > "hotpluggable-cpus": true,
> > "name": "pseries-4.2",
> > "numa-mem-supported": true,
> > "default-cpu-type": "host-powerpc64-cpu",
> > "is-default": true,
> > "cpu-max": 1024,
> > "deprecated": false,
> > "alias": "pseries"
> > },
> > {
> > "hotpluggable-cpus": true,
> > "name": "pseries-4.1",
> > "numa-mem-supported": true,
> > "default-cpu-type": "host-powerpc64-cpu",
> > "cpu-max": 1024,
> > "deprecated": false
> > },
> > ...
> >
> > Libvirt probes all machines via "-machine none,accel=kvm:tcg" and will
> > currently see the wrong CPU model under KVM.
>
> Will this patch make it into 4.2.0?
>
David is away until the 19th of November, which is the release date
of rc2 according to the planning [*]. Then we have rc3 the 26th, and
final release (or rc4) the 3rd of December, so it should be ok.
If David cannot make it for some reason, I guess Laurent Vivier or
myself can send a PR with this patch, as already suggested by David
in the past.
Cheers,
--
Greg
[*] https://wiki.qemu.org/Planning/4.2
> Jirka
>
>
