Patchew URL: https://patchew.org/QEMU/20191028163447.18541-1-phi...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge Type: series Message-id: 20191028163447.18541-1-phi...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1572316661-20043-1-git-send-email-jasow...@redhat.com -> patchew/1572316661-20043-1-git-send-email-jasow...@redhat.com - [tag update] patchew/20191025121930.6855-1-jfreim...@redhat.com -> patchew/20191025121930.6855-1-jfreim...@redhat.com Switched to a new branch 'test' 46be76b hw/pci-host/i440fx: Remove the last PIIX3 traces 2cf51fb hw/pci-host: Rename incorrectly named 'piix' as 'i440fx' c0a540f hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c 4395eed hw/pci-host/piix: Fix code style issues c354c0c hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h db7ce8b hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers da2451a hw/pci-host/piix: Move RCR_IOPORT register definition efaf219 hw/pci-host/piix: Extract piix3_create() e12eb18 hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers aeed9da hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c 0461951 hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create() cc00464 hw/mips/mips_malta: Create IDE hard drive array dynamically 4b74e4b piix4: Add a MC146818 RTC Controller as specified in datasheet 985bcb1 piix4: Add an i8254 PIT Controller as specified in datasheet cea90df piix4: Add an i8257 DMA Controller as specified in datasheet 2ff7d98 piix4: Rename PIIX4 object to piix4-isa 24b48ed Revert "irq: introduce qemu_irq_proxy()" 934a7ce piix4: Add an i8259 Interrupt Controller as specified in datasheet 6704ad5 piix4: Add the Reset Control Register d0325cb MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets === OUTPUT BEGIN === 1/20 Checking commit d0325cb965ae (MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets) 2/20 Checking commit 6704ad5b0f65 (piix4: Add the Reset Control Register) 3/20 Checking commit 934a7ce1b784 (piix4: Add an i8259 Interrupt Controller as specified in datasheet) 4/20 Checking commit 24b48ed294bf (Revert "irq: introduce qemu_irq_proxy()") 5/20 Checking commit 2ff7d987c8c8 (piix4: Rename PIIX4 object to piix4-isa) 6/20 Checking commit cea90dfe4978 (piix4: Add an i8257 DMA Controller as specified in datasheet) 7/20 Checking commit 985bcb1e5fbd (piix4: Add an i8254 PIT Controller as specified in datasheet) 8/20 Checking commit 4b74e4b098ec (piix4: Add a MC146818 RTC Controller as specified in datasheet) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #193: deleted file mode 100644 total: 0 errors, 1 warnings, 166 lines checked Patch 8/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/20 Checking commit cc004640d241 (hw/mips/mips_malta: Create IDE hard drive array dynamically) 10/20 Checking commit 0461951c8b55 (hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()) 11/20 Checking commit aeed9daa8921 (hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c) 12/20 Checking commit e12eb18a4875 (hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers) 13/20 Checking commit efaf219959f2 (hw/pci-host/piix: Extract piix3_create()) 14/20 Checking commit da2451ae6f96 (hw/pci-host/piix: Move RCR_IOPORT register definition) 15/20 Checking commit db7ce8b72831 (hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers) 16/20 Checking commit c354c0c68be0 (hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #98: new file mode 100644 total: 0 errors, 1 warnings, 101 lines checked Patch 16/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/20 Checking commit 4395eedc0400 (hw/pci-host/piix: Fix code style issues) 18/20 Checking commit c0a540fce82b (hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #65: new file mode 100644 ERROR: spaces required around that '*' (ctx:VxV) #314: FILE: hw/isa/piix3.c:245: + .subsections = (const VMStateDescription*[]) { ^ total: 1 errors, 1 warnings, 937 lines checked Patch 18/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/20 Checking commit 2cf51fb358e2 (hw/pci-host: Rename incorrectly named 'piix' as 'i440fx') WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: rename from hw/pci-host/piix.c total: 0 errors, 1 warnings, 32 lines checked Patch 19/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/20 Checking commit 46be76b017ba (hw/pci-host/i440fx: Remove the last PIIX3 traces) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191028163447.18541-1-phi...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
