Patchew URL: https://patchew.org/QEMU/20191028163447.18541-1-phi...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge Type: series Message-id: 20191028163447.18541-1-phi...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 9bb7350..aaffb85 master -> master - [tag update] patchew/20191028073441.6448-1-phi...@redhat.com -> patchew/20191028073441.6448-1-phi...@redhat.com - [tag update] patchew/20191028161841.1198-1-mre...@redhat.com -> patchew/20191028161841.1198-1-mre...@redhat.com Switched to a new branch 'test' 0010520 hw/pci-host/i440fx: Remove the last PIIX3 traces 43c1b70 hw/pci-host: Rename incorrectly named 'piix' as 'i440fx' 93d3159 hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c 6566f80 hw/pci-host/piix: Fix code style issues 50cfd9a hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h d13e160 hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers 5c260ce hw/pci-host/piix: Move RCR_IOPORT register definition e9b0d15 hw/pci-host/piix: Extract piix3_create() 8ad7223 hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers 7a6c877 hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c 6b61c1f hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create() 478f46b hw/mips/mips_malta: Create IDE hard drive array dynamically 8d3b7a2 piix4: Add a MC146818 RTC Controller as specified in datasheet bb1039e piix4: Add an i8254 PIT Controller as specified in datasheet 6412082 piix4: Add an i8257 DMA Controller as specified in datasheet 1afe231 piix4: Rename PIIX4 object to piix4-isa 89d9c4e Revert "irq: introduce qemu_irq_proxy()" 32546cc piix4: Add an i8259 Interrupt Controller as specified in datasheet efb3d0a piix4: Add the Reset Control Register d075937 MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets === OUTPUT BEGIN === 1/20 Checking commit d0759378cebd (MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets) 2/20 Checking commit efb3d0a1d195 (piix4: Add the Reset Control Register) 3/20 Checking commit 32546cc8d792 (piix4: Add an i8259 Interrupt Controller as specified in datasheet) 4/20 Checking commit 89d9c4e2ebe3 (Revert "irq: introduce qemu_irq_proxy()") 5/20 Checking commit 1afe231217a5 (piix4: Rename PIIX4 object to piix4-isa) 6/20 Checking commit 6412082c918f (piix4: Add an i8257 DMA Controller as specified in datasheet) 7/20 Checking commit bb1039edbd6f (piix4: Add an i8254 PIT Controller as specified in datasheet) 8/20 Checking commit 8d3b7a2e599b (piix4: Add a MC146818 RTC Controller as specified in datasheet) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #193: deleted file mode 100644 total: 0 errors, 1 warnings, 166 lines checked Patch 8/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/20 Checking commit 478f46bfa485 (hw/mips/mips_malta: Create IDE hard drive array dynamically) 10/20 Checking commit 6b61c1fbacd7 (hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()) 11/20 Checking commit 7a6c8773f6fd (hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c) 12/20 Checking commit 8ad72237df28 (hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers) 13/20 Checking commit e9b0d15a53b5 (hw/pci-host/piix: Extract piix3_create()) 14/20 Checking commit 5c260ce9ab3f (hw/pci-host/piix: Move RCR_IOPORT register definition) 15/20 Checking commit d13e160a59fb (hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers) 16/20 Checking commit 50cfd9a882f1 (hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #98: new file mode 100644 total: 0 errors, 1 warnings, 101 lines checked Patch 16/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/20 Checking commit 6566f806c1de (hw/pci-host/piix: Fix code style issues) 18/20 Checking commit 93d315999f4a (hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #65: new file mode 100644 ERROR: spaces required around that '*' (ctx:VxV) #314: FILE: hw/isa/piix3.c:245: + .subsections = (const VMStateDescription*[]) { ^ total: 1 errors, 1 warnings, 937 lines checked Patch 18/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/20 Checking commit 43c1b70b4651 (hw/pci-host: Rename incorrectly named 'piix' as 'i440fx') WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: rename from hw/pci-host/piix.c total: 0 errors, 1 warnings, 32 lines checked Patch 19/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/20 Checking commit 0010520a5c7a (hw/pci-host/i440fx: Remove the last PIIX3 traces) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191028163447.18541-1-phi...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
